Skip to content

Conversation

@JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Dec 14, 2023

PLEASE READ

Following a recent back-end update, all contributors with a local clone or fork of our repository are required to run yarn install. This does not apply to direct page edits.

  • Yes, I've run yarn install
  • No, does not apply to me

Purpose of this pull request

This pull request...

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions, .clabot
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Dec 14, 2023
@JV0812 JV0812 marked this pull request as draft December 14, 2023 14:50
@JV0812 JV0812 self-assigned this Dec 14, 2023
@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Dec 14, 2023
…amework/cloudquery-source.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, @JV0812. I found only a few things.

@jpipkin1
Copy link
Collaborator

@JV0812, you should probably also add CloudQuery here:
http://localhost:3000/docs/integrations/product-list/#c

@jpipkin1
Copy link
Collaborator

@JV0812, I just realized this was a draft! Sorry I put in review comments when you weren't done working on it.

@JV0812
Copy link
Collaborator Author

JV0812 commented Dec 18, 2023

Its okay @jpipkin1. Thanks for your quick review and feedback. I will incorporate the points you have mentioned and will submit the PR for review.

@JV0812 JV0812 requested a review from jpipkin1 December 19, 2023 09:36
@JV0812 JV0812 marked this pull request as ready for review December 19, 2023 09:36
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @JV0812!

@JV0812 JV0812 removed the do-not-merge Pull requests that should not be merged label Mar 22, 2024
@JV0812 JV0812 enabled auto-merge March 22, 2024 04:53
@JV0812 JV0812 added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit f3c0ae7 Mar 22, 2024
@JV0812 JV0812 deleted the CloudQuery-source-doc branch March 22, 2024 05:17
@jpipkin1
Copy link
Collaborator

@JV0812, we’re removing the CloudQuery Source beta article with PR #4209 at the request of @arpit Jaiswal (see Slack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants