Skip to content

Conversation

@JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Jun 3, 2024

Purpose of this pull request

This pull request is to update the app installation steps as per V2. Also, add updating and deleting the app information.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

Doc changes for the migrated V2 apps which are using Threat Intel

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jun 3, 2024
@JV0812 JV0812 self-assigned this Jun 3, 2024
@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Jun 3, 2024
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! minor fixes

@JV0812 JV0812 requested review from a team and amee-sumo as code owners April 4, 2025 05:50
@jpipkin1
Copy link
Collaborator

jpipkin1 commented Apr 4, 2025

@JV0812, this PR has some merge conflicts. Let me know when you've resolved them, and I'll give it a review.

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, @JV0812.

I removed the FAQ section from the Threat Intel article because it talks about CrowdStrike, and we are removing the CrowdStrike source from threat intel by the end of the month. See my commit "Remove FAQ section from Threat Intel Quick Analysis article".

Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation - otherwise looks great

@soc-service-agent
Copy link

soc-service-agent commented Apr 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@JV0812 JV0812 removed the do-not-merge Pull requests that should not be merged label May 2, 2025
@JV0812 JV0812 added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit d304e71 May 2, 2025
7 checks passed
@JV0812 JV0812 deleted the V1-to-V2-apps-migration branch May 2, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants