Skip to content

Conversation

@JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Oct 13, 2024

Purpose of this pull request

This pull request is to create audit logging migration instructions in this article:
https://help.sumologic.com/docs/api/role-management-v2/

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

DOCS-493 and SUMO-248932

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Oct 13, 2024
@JV0812 JV0812 self-assigned this Oct 13, 2024
@JV0812 JV0812 marked this pull request as draft October 13, 2024 10:15
@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Oct 14, 2024
@JV0812 JV0812 marked this pull request as ready for review October 14, 2024 10:58
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JV0812, thank you for taking this work in my absence. I have only a couple of suggestions.

@jpipkin1 jpipkin1 assigned jpipkin1 and unassigned JV0812 Oct 14, 2024
@jpipkin1
Copy link
Collaborator

@atishya-22, rather than publishing the migration instructions as a separate article, I added it as a section in the “Role Management APIs (V2)” article.

Could you review it for me?

@jpipkin1 jpipkin1 changed the title Migrate Audit Logging from V1 to V2 docs DOCS-493 - Migrate Audit Logging from V1 to V2 docs Oct 16, 2024
@jpipkin1
Copy link
Collaborator

@atishya-22 replied via Slack:

looks good to me. I’ll ask @Manas Sharma to take a look

@jpipkin1 jpipkin1 enabled auto-merge October 18, 2024 15:33
@jpipkin1 jpipkin1 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 1dfc01f Oct 18, 2024
5 checks passed
@jpipkin1 jpipkin1 deleted the rbac-v1-to-v2-audit-logging-migration-doc branch October 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants