Skip to content

Conversation

@ankurch627
Copy link
Contributor

@ankurch627 ankurch627 commented Nov 26, 2024

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

Copy link
Contributor

@himanshu219 himanshu219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

@jpipkin1 jpipkin1 marked this pull request as draft November 26, 2024 15:38
@jpipkin1
Copy link
Collaborator

@ankurch627, I converted the PR to a draft because you have "Draft" in the title. When the PR is ready for review, click the Ready for review button.

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Nov 26, 2024
@ankurch627 ankurch627 changed the title Draft: Doc changes Azure ASE Doc changes Azure ASE Nov 27, 2024
@ankurch627
Copy link
Contributor Author

@jpipkin1 unable to find the Ready for review button. Can you please help? The PR is ready for review

@JV0812 JV0812 marked this pull request as ready for review November 27, 2024 10:31
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@himanshu219 himanshu219 requested a review from JV0812 November 29, 2024 05:37
@himanshu219 himanshu219 self-requested a review November 29, 2024 05:37
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JV0812 JV0812 enabled auto-merge November 29, 2024 05:46
@JV0812 JV0812 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 6baf1d9 Nov 29, 2024
7 checks passed
@JV0812 JV0812 deleted the SUMO-250133 branch November 29, 2024 06:09
himanshu219 added a commit that referenced this pull request Nov 30, 2024
* updated doc for ASE

* resolved PR comments

* resolved PR comments - added diagnostic settings screenshot

* resolved pr comments

* resolved pr comments

* resolved pr comments

* Delete docs/integrations/microsoft-azure/test.json

* Minor fix

---------

Co-authored-by: Himanshu Pal <[email protected]>
Co-authored-by: Jagadisha V <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants