Skip to content

Conversation

@JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Dec 16, 2024

Purpose of this pull request

This pull request is to update the V2 apps with the latest appflow, through which the user can configure the data collection while installing the app.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

Required doc change for new app flow.

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Dec 16, 2024
@JV0812 JV0812 marked this pull request as draft December 16, 2024 12:46
@JV0812 JV0812 self-assigned this Dec 16, 2024
@JV0812 JV0812 marked this pull request as ready for review December 18, 2024 05:33
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JV0812, your work looks good. But you should consider creating a reuse file.

@JV0812 JV0812 requested a review from jpipkin1 December 20, 2024 06:44
Copy link
Collaborator

@amee-sumo amee-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@JV0812 JV0812 requested a review from himanshu219 December 20, 2024 10:58
@JV0812 JV0812 dismissed jpipkin1’s stale review December 20, 2024 11:11

Thanks for your review John. I fixed your suggestions.

@JV0812 JV0812 enabled auto-merge December 20, 2024 11:22
@JV0812 JV0812 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit a5c524d Dec 20, 2024
7 checks passed
@JV0812 JV0812 deleted the app-integration-reuse-file branch December 20, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants