Skip to content

Conversation

@parth-sumo
Copy link
Collaborator

@parth-sumo parth-sumo commented Jan 2, 2025

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jan 2, 2025
Copy link
Collaborator

@amee-sumo amee-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parth-sumo I made a few suggestions.

@parth-sumo parth-sumo requested a review from amee-sumo January 3, 2025 05:55
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed some of the minor issues through this commit. Can you just add the image to S3 once available and create a release note for the release (Ref: https://help.sumologic.com/release-notes-service/2024/12/31/#cisco-amp)

@parth-sumo
Copy link
Collaborator Author

I have fixed some of the minor issues through this commit. Can you just add the image to S3 once available and create a release note for the release (Ref: https://help.sumologic.com/release-notes-service/2024/12/31/#cisco-amp)

I don't have access for the same. The app is under review as of now, will create the release note once everything is ready.

@parth-sumo parth-sumo requested a review from JV0812 January 6, 2025 09:56
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@amee-sumo amee-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himanshu219 himanshu219 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into SumoLogic:main with commit df0cff2 Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants