Skip to content

DOCS-617: Created doc for Jamf App #4917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 10, 2025
Merged

DOCS-617: Created doc for Jamf App #4917

merged 12 commits into from
Jan 10, 2025

Conversation

@darshan-sumo
Copy link
Contributor

@darshan-sumo darshan-sumo commented Jan 2, 2025 •
edited by JV0812
Loading

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot
Copy link

cla-bot bot commented Jan 2, 2025

Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we will add you to our approved list of contributors.

@jpipkin1 jpipkin1 mentioned this pull request Jan 2, 2025
Merged
4 tasks
jpipkin1
jpipkin1 reviewed Jan 2, 2025
View reviewed changes
@cla-bot
Copy link

cla-bot bot commented Jan 2, 2025

Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we will add you to our approved list of contributors.

jpipkin1
jpipkin1 requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darshan-sumo, can you fix access permission to the dashboard images? Everything else looks good.

I added the app to the left nav and the product list (see commit "Add Jamf app to left nav").

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jan 2, 2025
JV0812
JV0812 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpipkin1
Copy link
Collaborator

jpipkin1 commented Jan 3, 2025

@darshan-sumo, can we go ahead and publish this PR?

JV0812
JV0812 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JV0812 JV0812 enabled auto-merge January 10, 2025 11:56
@JV0812 JV0812 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into SumoLogic:main with commit e0de648 Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@JV0812 JV0812 JV0812 approved these changes

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

@himanshu219 himanshu219 Awaiting requested review from himanshu219

Assignees

@darshan-sumo darshan-sumo

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darshan-sumo @jpipkin1 @JV0812