Skip to content

Otel Collector tags information added #5050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 20, 2025
Merged

Otel Collector tags information added #5050

merged 13 commits into from
Feb 20, 2025

Conversation

@JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Feb 10, 2025 •
edited
Loading

Purpose of this pull request

This pull request is to add OTEL collector tags details to the doc.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

Add documentation for Update tags

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Feb 10, 2025
@JV0812 JV0812 self-assigned this Feb 10, 2025
@JV0812 JV0812 marked this pull request as draft February 10, 2025 06:19
@JV0812 JV0812 marked this pull request as ready for review February 12, 2025 04:53
jpipkin1
jpipkin1 reviewed Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @JV0812. I have only minor comments. I'd avoid using "/" in sentences.

@jpipkin1
Copy link
Collaborator

jpipkin1 commented Feb 17, 2025

@JV0812, does this PR need a do-not-merge label?

JV0812 and others added 4 commits February 20, 2025 10:54
@JV0812 @jpipkin1
Update docs/send-data/opentelemetry-collector/remote-management/sourc…
2f81c25 
…e-templates/manage-source-templates.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
@JV0812 @jpipkin1
Update docs/send-data/opentelemetry-collector/remote-management/sourc…
54b76a9 
…e-templates/manage-source-templates.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
@JV0812 @jpipkin1
Update docs/send-data/opentelemetry-collector/remote-management/sourc…
52a09f5 
…e-templates/manage-source-templates.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
@JV0812 @jpipkin1
Update docs/send-data/opentelemetry-collector/remote-management/sourc…
29cc237 
…e-templates/manage-source-templates.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Feb 20, 2025
@JV0812 JV0812 removed the do-not-merge Pull requests that should not be merged label Feb 20, 2025
@JV0812
Copy link
Collaborator Author

JV0812 commented Feb 20, 2025

Thanks for your review and feedback John. This PR is good to merge now.

@JV0812 JV0812 added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 53c088f Feb 20, 2025
5 checks passed
@JV0812 JV0812 deleted the add-collector-tag-details branch February 20, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

Assignees

@JV0812 JV0812

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JV0812 @jpipkin1