Skip to content

Conversation

@mahendrak-sumo
Copy link
Collaborator

@mahendrak-sumo mahendrak-sumo commented Apr 26, 2025

…ration

Purpose of this pull request

The action was failing with an error like no resourcefound error for resource incidents, the issue was with next_link attribute which we got from the response and we were adding the params to it regardless it had the params automatically.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Apr 26, 2025
@mahendrak-sumo mahendrak-sumo changed the title CSOAR-3221 : API Error NoRegisteredProviderFound on MS Sentinel Integ… CSOAR-3221 : API Error NoRegisteredProviderFound on MS Sentinel Integration Apr 26, 2025
@mahendrak-sumo mahendrak-sumo marked this pull request as draft April 26, 2025 18:27
@jpipkin1
Copy link
Collaborator

jpipkin1 commented May 7, 2025

@mahendrak-sumo, please provide instructions to customers for the fields on the configuration dialog for this integration. I know it's out of scope for this ticket, but from now on when I review PRs for integrations I will ask developers to provide information for the configuration dialog.

microsoft-sentinel-configuration

@mahendrak-sumo
Copy link
Collaborator Author

but from now on when I review PRs for integrations I will ask developers to provide information for the configuration dialog.

Yes @jpipkin1 , I am working on this as par the latest document contents.

@mahendrak-sumo mahendrak-sumo marked this pull request as ready for review May 8, 2025 11:21
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, @mahendrak-sumo. I made some minor changes (see commit "Updates from review").

@jpipkin1 jpipkin1 enabled auto-merge May 8, 2025 15:09
@jpipkin1 jpipkin1 added this pull request to the merge queue May 8, 2025
Merged via the queue into SumoLogic:main with commit 4498ad3 May 8, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants