Source template feature for Timestamp parsing #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JV0812 merged 13 commits into main from otelTimestamp

Jul 10, 2025

Collaborator

sumoanema commented Jul 4, 2025

Purpose of this pull request

This pull request is to update timestamp parsing feature doc with some more details and making source template with timestamp parsing to redirect to it.

Select the type of change

Minor Changes - Typos, formatting, slight revisions
Update Content - Revisions, updating sections
New Content - New features, sections, pages, tutorials
Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/SUMO-258774


          Source template feature for Timestamp parsing

530324e

sumoanema requested review from a team, JV0812, amee-sumo, jpipkin1, kimsauce and mafsumo as code owners

July 4, 2025 06:52

cla-bot bot added the cla-signed label

JV0812 assigned sumoanema and JV0812

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved


          Update otrmTimestampParsing.md

b4bf90e

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 reviewed

View reviewed changes

...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md Outdated Show resolved Hide resolved

jpipkin1 previously requested changes

View reviewed changes

Collaborator

jpipkin1 left a comment

@sumoanema, this looks very good. It just needs a few minor updates.

sumoanema and others added 3 commits

July 7, 2025 20:25


          Apply suggestions from code review

62bce84

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>


          comments incorporated

69b598d


          Merge branch 'main' into otelTimestamp

064e66b

JV0812 requested a review from jpipkin1

July 8, 2025 12:14


          Fix broken links

a165adb


          Minor change to link text

e75b65b

jpipkin1 reviewed

View reviewed changes

Collaborator

jpipkin1 left a comment

Approved, @JV0812. It looks great.

jpipkin1 dismissed their stale review

July 8, 2025 13:37

Re-reviewed and approved.

JV0812 approved these changes

View reviewed changes

Collaborator

JV0812 left a comment

LGTM

kimsauce mentioned this pull request

Replace otelcol timestamp /reuse reference #5566

Merged

4 tasks

kimsauce previously requested changes

View reviewed changes

Collaborator

kimsauce left a comment

Hi @sumoanema , i've proposed changes to your PR that utilizes a /reuse file, includes a few minor fixes, adds cross-references between the general and OTRM time refs, and fixes an extraneous markup in an image.

Collaborator Author

sumoanema commented Jul 9, 2025 •

edited

Loading

Thanks @kimsauce , the PR #5566 looks perfect. Should we close this PR. And can you merge the other PR


          Merge branch 'main' into otelTimestamp

44723f5

Collaborator

kimsauce commented Jul 9, 2025

Thanks @kimsauce , the PR #5566 looks perfect. Should we close this PR. And can you merge the other PR

thanks for reviewing! I've set it up so that it will merge into yours once approved -- i'll do that now.


          Replace otelcol timestamp /reuse reference (#5566)

f676253

* Replace otelcol timestamp /reuse reference

* cross-references

* Update docs/send-data/opentelemetry-collector/remote-management/source-templates/postgresql/index.md

* Update docs/send-data/opentelemetry-collector/remote-management/source-templates/rabbitmq/index.md

* Update docs/send-data/opentelemetry-collector/remote-management/source-templates/redis/index.md

* Update docs/send-data/opentelemetry-collector/remote-management/source-templates/otrm-time-reference.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>

* Update docs/reuse/apps/opentelemetry/timestamp-parsing.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>

---------

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>

kimsauce self-requested a review

July 9, 2025 19:51

Collaborator Author

sumoanema commented Jul 10, 2025

@kimsauce thanks !! Will track this PR then.

JV0812 and others added 4 commits

July 10, 2025 10:15


          Fixes from the comments PR:5566

9605aa2


          Merge branch 'otelTimestamp' of https://github.com/SumoLogic/sumologi…

2e8bd94

…c-documentation into otelTimestamp


          minor fixes

94a92a7


          Merge branch 'main' into otelTimestamp

a7f2115

JV0812 dismissed kimsauce’s stale review

July 10, 2025 05:32

Incorporated the changes. Thanks Kim!

JV0812 added this pull request to the merge queue

Merged via the queue into main with commit b348bea

7 checks passed

JV0812 deleted the otelTimestamp branch

July 10, 2025 05:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jpipkin1 jpipkin1 left review comments

JV0812 JV0812 approved these changes

mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

Labels