Changes for full vnet integration of data collected through block blo… #5841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumoanema
requested review from
JV0812,
amee-sumo,
jpipkin1,
kimsauce and
mafsumo
as code owners
jpipkin1
reviewed
Sep 26, 2025
...-data/collect-from-other-data-sources/azure-blob-storage/block-blob/full-vnet-integration.md
Outdated
Show resolved
Hide resolved
jpipkin1
requested changes
Sep 26, 2025
Collaborator
jpipkin1
left a comment
jpipkin1
left a comment
There was a problem hiding this comment.
@sumoanema, I made minor changes (see commit "Updates from review").
…creenshot. Vnet integration is not associated with multi storage account - have made it a seperate step
…et integration. Thus removing the step to copy and paste static ip from vnet integration steps
Collaborator
|
@amee-sumo, can you fix the build break on this PR? When you changed the ID on the file you also needed to change the corresponding file ID in the sidebar file. |
jpipkin1
approved these changes
Sep 29, 2025
Collaborator
jpipkin1
reviewed
Sep 29, 2025
...-data/collect-from-other-data-sources/azure-blob-storage/block-blob/full-vnet-integration.md
Outdated
Show resolved
Hide resolved
jpipkin1
requested changes
Sep 29, 2025
Collaborator
jpipkin1
left a comment
jpipkin1
left a comment
There was a problem hiding this comment.
It looks pretty good, @amee-sumo. But I think you should fix the indenting on all the steps so that it flows a little better.
…age/block-blob/full-vnet-integration.md Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
jpipkin1
approved these changes
Sep 30, 2025
Collaborator
jpipkin1
left a comment
jpipkin1
left a comment
There was a problem hiding this comment.
Approved, @sumoanema. I added indents with the commit "Adjust indenting".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Changes for full VNet integration of data collected through block blob arm template
Select the type of change
Ticket (if applicable)
SUMO-270888