Added druid ingestion spec for vdn contents#264
Open
ishawakankar wants to merge 2 commits intoSunbird-Ed:release-3.3.0from
Open
Added druid ingestion spec for vdn contents#264ishawakankar wants to merge 2 commits intoSunbird-Ed:release-3.3.0from
ishawakankar wants to merge 2 commits intoSunbird-Ed:release-3.3.0from
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
SanthoshVasabhaktula
requested changes
Oct 27, 2020
Collaborator
SanthoshVasabhaktula
left a comment
SanthoshVasabhaktula
left a comment
There was a problem hiding this comment.
Handle array fields properly
| { | ||
| "type": "path", | ||
| "name": "acceptedContents", | ||
| "expr": "$.data.acceptedContents" |
Collaborator
There was a problem hiding this comment.
These are array items right? shouldn't they be indexed as array?
Comment on lines
+44
to
+46
| "type": "path", | ||
| "name": "rejectedContents", | ||
| "expr": "$.data.rejectedContents" |
Collaborator
There was a problem hiding this comment.
Add a transform spec and convert the array to sizes - acceptedContentsSize and rejectedContentsSize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.