Issue #SBCOSS-00: Migrate Keycloak config to config-based approach and fix ClassCastException in managedUsers

[chethann007]

Summary

This PR refactors and stabilizes the user-deletion-cleanup Flink Job by:

Refactor

• Migrating Keycloak configuration from environment variables to a centralized UserDeletionCleanupConfig.
• Replacing hardcoded environment variable references in KeyCloakConnectionProvider with config-based properties.
• Updating KeyCloakConnectionProvider constructor to accept UserDeletionCleanupConfig.
• Using a configuration value for connection pool size instead of a hardcoded string.
• Grouping Keycloak-related configuration properties for better organization and maintainability.

Fix

• Handling ClassCastException in managedUsers method with proper type checking.
• Correcting deletionStatus assignment in UserDeletionCleanupFunction for accurate audit tracking.
• Adding logging for URL and response status during the user deletion process for better traceability.

Chore

• Adding Maven Shade Plugin configuration for packaging the job into a single executable JAR.

Description by Korbit AI

What change is being made?

Migrate Keycloak configuration to a config-based approach and resolve a ClassCastException in the managedUsers function within the user deletion cleanup module.

Why are these changes being made?

The Keycloak configuration previously depended on environment variables, which was less efficient and hard to manage. Transitioning to a config-based setup enhances maintainability and scalability. Additionally, handling potential ClassCastException in managedUsers ensures smoother and more robust data processing when user deletion cleanup jobs are executed.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Exposed Sensitive Keycloak Credentials in Memory ▹ view
	Unsafe List Type Casting ▹ view
	Insufficient Keycloak Configuration Context ▹ view	✅ Fix detected
	Mismatched Config Keys and Variable Names ▹ view

Files scanned

​

File Path	Reviewed
user-org-jobs/user-deletion-cleanup/src/main/scala/org/sunbird/job/deletioncleanup/domain/Event.scala	✅
user-org-jobs/user-deletion-cleanup/src/main/scala/org/sunbird/job/deletioncleanup/task/UserDeletionCleanupConfig.scala	✅
user-org-jobs/user-deletion-cleanup/src/main/scala/org/sunbird/job/deletioncleanup/util/KeyCloakConnectionProvider.scala	✅
user-org-jobs/user-deletion-cleanup/src/main/scala/org/sunbird/job/deletioncleanup/functions/UserDeletionCleanupFunction.scala	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[Copilot]

Pull Request Overview

This PR refactors the user-deletion-cleanup Flink job to improve configuration management and fix runtime errors. It migrates Keycloak configuration from environment variables to a centralized config-based approach and addresses a ClassCastException in the managedUsers method.

• Centralized Keycloak configuration in UserDeletionCleanupConfig class
• Fixed ClassCastException with proper type checking in Event.managedUsers method
• Corrected variable assignment issues in deletion status tracking

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
KeyCloakConnectionProvider.scala	Updated constructor to accept config object and replaced environment variable calls with config properties
UserDeletionCleanupConfig.scala	Added Keycloak configuration properties with centralized management
UserDeletionCleanupFunction.scala	Fixed deletion status assignment and updated Keycloak provider instantiation
Event.scala	Enhanced managedUsers method with robust type checking to handle ClassCastException
pom.xml	Added Maven Shade Plugin configuration for executable JAR packaging

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}