fix(code-quality): Replace System.out.println with SLF4J, fix log string concatenation#8
Open
maheshkumargangula wants to merge 2 commits intodevelopfrom
Open
fix(code-quality): Replace System.out.println with SLF4J, fix log string concatenation#8maheshkumargangula wants to merge 2 commits intodevelopfrom
maheshkumargangula wants to merge 2 commits intodevelopfrom
Conversation
…ing concatenation
- Replace System.out.println in StartModule, ApplicationStart, ActorStartModule (CQ-02)
- Replace System.out.println in CollectionSummaryAggregateController (CQ-02)
- Replace System.out.println in CacheManagementActor (CQ-02)
- Fix parameterized logging in SearchTelemetryUtil, ElasticSearchRestHighImpl (CQ-10)
- Fix log string concatenation to use {} placeholders (CQ-10)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…S log literals
- ApplicationStart.java: remove duplicate LoggerUtil declaration in
mockServiceSetup(), restore brace balance, fix log call to use
parameterized format with e.getMessage()
- ElasticSearchRestHighImpl.java: fix 4 broken multi-line string literals
in update(), getDataByIdentifier(), bulkInsert() and upsert() methods
that would cause compilation errors; convert to single-line parameterized
SLF4J format with {} placeholders
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
fix(code-quality): Replace System.out.println with SLF4J, fix log string concatenation
Base Branch
develop
Summary
System.out.printlncalls in LMS service startup classes and controllers with appropriate SLF4Jlogger.info()/logger.debug()calls{}placeholder pattern — avoids string building when log level is disabledFiles Changed
modules/lms/service/app/modules/StartModule.javamodules/lms/service/app/modules/ApplicationStart.javamodules/lms/service/app/modules/ActorStartModule.javamodules/lms/service/app/controllers/collectionsummaryaggregate/CollectionSummaryAggregateController.javamodules/lms/course-mw/course-actors-common/.../CacheManagementActor.javamodules/lms/course-mw/course-actors-common/.../SearchTelemetryUtil.javacore/sunbird-es-utils/.../ElasticSearchRestHighImpl.javamodules/userorg/controller/.../RequestInterceptor.javaImplements Tasks
CQ-02, CQ-10
Test Plan
grep -rn "System.out.print" modules/ core/ --include="*.java" | grep -v "/test/"→ 0 resultsmvn clean install -DskipTests