Issue #SBCOSS-00 : Fix Scala Conversions and Addition of public key base path to config#159
Merged
pallakartheekreddy merged 3 commits intoSunbird-Lern:release-8.1.0from Dec 15, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Scala collection conversion issues and adds a public key base path configuration. The changes introduce a centralized utility method to handle type conversions and eliminate dependencies on Scala's JavaConverters.
- Introduces a new
convertToListutility method to handle object-to-list conversions - Replaces Scala collection conversion logic with the new utility method in NotificationActor and CreateNotificationActor
- Adds
accesstoken.publickey.basepathconfiguration property to notification.config.properties
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| sb-utils/src/main/resources/notification.config.properties | Adds public key base path configuration for access token validation |
| all-actors/src/main/java/org/sunbird/util/Util.java | Introduces convertToList utility method with ObjectMapper instances for type conversion |
| all-actors/src/main/java/org/sunbird/notification/actor/NotificationActor.java | Replaces direct casting with Util.convertToList for notifications list conversion |
| all-actors/src/main/java/org/sunbird/notification/actor/CreateNotificationActor.java | Removes Scala JavaConverters dependency and uses Util.convertToList instead |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
pallakartheekreddy
merged commit eaf6c11
into
Sunbird-Lern:release-8.1.0
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.