Rework Required Bosses #150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bosses currently are required by virtue of their Heart Container checks dropping an item which is required to beat the game. This PR changes the behavior to instead check that all required bosses are defeated when the door to the Puppet Ganon room opens up.
The implementation on the gamecube randomizer uses a completely custom actor to achieve this, but that seemed like something out of my wheelhouse. So instead I hooked into the execute function for the ALLdie actor and if the current stage is the final staircase in Ganon's Tower, then an additional check is run to see that all required bosses are defeated before the flag is set by the ALLdie actor for killing all the enemies in the room. This has the slight disadvantage of the enemies respawning in the room if the player comes through and kills them all, but doesn't have all the required bosses beaten. Though this is very minor in the grand scheme of things.
I tested defeating each boss individually as well as all 6 bosses required for the door functionality and it all worked as expected.