Removed barrel imports as these create issues when compiling/building…#26
Merged
Removed barrel imports as these create issues when compiling/building…#26
Conversation
…. Refactored some minor return types
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes barrel file exports (index.ts files) and replaces them with direct imports to resolve compilation/build issues. The changes improve the build process by eliminating re-export patterns that can cause circular dependency and bundling problems.
Key Changes
- Removed all barrel file exports (
index.tsfiles exporting*from other modules) - Updated all imports throughout the codebase to reference specific files directly
- Added explicit return type annotations to various functions
Reviewed Changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/superofficedx-vscode-tsfso/src/extension.ts | Updated to import specific types and added return type annotations |
| packages/superofficedx-vscode-crmscript/src/DslLibraryFileSystemProvider.ts | Added void return type annotations to class methods |
| packages/superofficedx-vscode-core/src/utils.ts | Changed from barrel import to direct file import |
| packages/superofficedx-vscode-core/src/types/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/services/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/providers/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/handlers/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/container/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/container/core/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/container/configurations/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/commands/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/commands/types/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/commands/implementations/script/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/commands/implementations/auth/index.ts | Removed barrel exports file |
| packages/superofficedx-vscode-core/src/commands/handlers/index.ts | Removed barrel exports file |
| Multiple test files | Updated imports to use direct file references instead of barrel imports |
| Multiple service/handler/provider files | Updated imports and added explicit return type annotations |
| packages/language-server/src/*.ts | Added return type annotations to functions |
| packages/langium-crmscript/src/language/crmscript-validator.ts | Added return type annotations to validator functions |
Comments suppressed due to low confidence (2)
packages/superofficedx-vscode-core/src/services/httpService.ts:1
- Multiple imports from the same file should be combined into a single import statement. Lines 4, 5, 7, and 8 all import from '../types/script' and can be consolidated.
packages/superofficedx-vscode-core/src/services/nodeService.ts:1 - Commented-out code should be removed rather than left in the codebase.
packages/superofficedx-vscode-core/src/commands/implementations/script/viewDetails.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/commands/implementations/script/executeLocally.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/commands/implementations/script/execute.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/commands/implementations/script/downloadFolder.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/commands/implementations/script/preview.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/commands/implementations/script/download.ts
Outdated
Show resolved
Hide resolved
…s/script/viewDetails.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/executeLocally.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/execute.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/downloadFolder.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/preview.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/download.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…. Refactored some minor return types