Skip to content

Removed barrel imports as these create issues when compiling/building…#26

Merged
ejfasting merged 7 commits intomainfrom
Feature/EF/remove_barrel_imports_core
Nov 17, 2025
Merged

Removed barrel imports as these create issues when compiling/building…#26
ejfasting merged 7 commits intomainfrom
Feature/EF/remove_barrel_imports_core

Conversation

@ejfasting
Copy link
Copy Markdown
Member

…. Refactored some minor return types

@ejfasting ejfasting requested a review from Copilot November 17, 2025 12:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes barrel file exports (index.ts files) and replaces them with direct imports to resolve compilation/build issues. The changes improve the build process by eliminating re-export patterns that can cause circular dependency and bundling problems.

Key Changes

  • Removed all barrel file exports (index.ts files exporting * from other modules)
  • Updated all imports throughout the codebase to reference specific files directly
  • Added explicit return type annotations to various functions

Reviewed Changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/superofficedx-vscode-tsfso/src/extension.ts Updated to import specific types and added return type annotations
packages/superofficedx-vscode-crmscript/src/DslLibraryFileSystemProvider.ts Added void return type annotations to class methods
packages/superofficedx-vscode-core/src/utils.ts Changed from barrel import to direct file import
packages/superofficedx-vscode-core/src/types/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/services/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/providers/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/handlers/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/container/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/container/core/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/container/configurations/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/commands/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/commands/types/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/commands/implementations/script/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/commands/implementations/auth/index.ts Removed barrel exports file
packages/superofficedx-vscode-core/src/commands/handlers/index.ts Removed barrel exports file
Multiple test files Updated imports to use direct file references instead of barrel imports
Multiple service/handler/provider files Updated imports and added explicit return type annotations
packages/language-server/src/*.ts Added return type annotations to functions
packages/langium-crmscript/src/language/crmscript-validator.ts Added return type annotations to validator functions
Comments suppressed due to low confidence (2)

packages/superofficedx-vscode-core/src/services/httpService.ts:1

  • Multiple imports from the same file should be combined into a single import statement. Lines 4, 5, 7, and 8 all import from '../types/script' and can be consolidated.
    packages/superofficedx-vscode-core/src/services/nodeService.ts:1
  • Commented-out code should be removed rather than left in the codebase.

ejfasting and others added 6 commits November 17, 2025 13:41
…s/script/viewDetails.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/executeLocally.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/execute.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/downloadFolder.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/preview.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/script/download.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ejfasting ejfasting self-assigned this Nov 17, 2025
@ejfasting ejfasting merged commit b8a85d1 into main Nov 17, 2025
2 checks passed
@ejfasting ejfasting deleted the Feature/EF/remove_barrel_imports_core branch November 17, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants