Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Playwright for end-to-end testing of the VS Code extension, restructures the test directory, and refactors the authentication service to support testability. The changes enable automated UI testing of the extension's OAuth flow and command execution.
- Adds Playwright test framework with E2E tests for OAuth flow and extension commands
- Restructures test organization (unit tests under
tests/unit/vitest/, E2E undertests/e2e/playwright/) - Refactors
AuthenticationServiceto extractgenerateAuthorizeUrlfor better testability
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
vitest.config.ts |
Updates project reference and adds esbuild target configuration |
test-results/.last-run.json |
Adds test results file (should be gitignored) |
packages/superofficedx-vscode-core/vitest.config.ts |
Updates test paths and coverage configuration with incorrect include pattern |
packages/superofficedx-vscode-core/vitest-setup.ts |
Adds VS Code API mocking setup for Vitest tests |
packages/superofficedx-vscode-core/tests/unit/vitest/**/*.test.ts |
Updates import paths to match new directory structure |
packages/superofficedx-vscode-core/tests/e2e/playwright/workbox.ts |
Adds Playwright fixture for launching VS Code with extension |
packages/superofficedx-vscode-core/tests/e2e/playwright/oauth-flow.spec.ts |
Adds E2E tests for OAuth sign-in flow |
packages/superofficedx-vscode-core/tests/e2e/playwright/basic.spec.ts |
Adds basic E2E smoke tests for extension loading |
packages/superofficedx-vscode-core/src/services/authenticationService.ts |
Refactors login logic by extracting URL generation into testable method |
packages/superofficedx-vscode-core/playwright.config.ts |
Configures Playwright for VS Code extension testing |
packages/superofficedx-vscode-core/package.json |
Removes ESM mode, pins dependency versions including invalid esbuild version |
package.json |
Updates root dependencies with invalid esbuild version |
.github/general-coding.instructions.md |
Adds general coding standards documentation |
.github/copilot-instructions.md |
Updates with TypeScript guidelines and reorganized structure |
packages/superofficedx-vscode-core/src/services/authenticationService.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/services/authenticationService.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/services/authenticationService.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/services/authenticationService.ts
Outdated
Show resolved
Hide resolved
…Service.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Service.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Service.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.