Skip to content

Fix WalkingBadguy getting stuck on curved tiles (#3239) #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix WalkingBadguy getting stuck on curved tiles (#3239) #3252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/badguy/walking_badguy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,21 @@ WalkingBadguy::collision_solid(const CollisionHit& hit)
if (m_physic.get_velocity_y() > 0) m_physic.set_velocity_y(0);
}

if ( hit.slope_normal.x == 0.0f &&
((hit.left && m_dir == Direction::LEFT) ||
(hit.right && m_dir == Direction::RIGHT)) ) {
if ((hit.left && m_dir == Direction::LEFT) ||
(hit.right && m_dir == Direction::RIGHT)) {

// Enemies get stuck in some tiles #3239 FIX
// When a bad guy is about to step onto a slope, have it manually step onto it
if (std::abs(hit.slope_normal.x) > 0.0f && std::abs(hit.slope_normal.x) < 0.7f) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe move the std::abs(hit.slope_normal.x) into a variable? That way, this if statement would fit into a line

Vector movement = m_col.get_movement();
movement.y -= 5;
m_col.set_movement(movement);
// setting the movement of the CollisionObject
} else {
// If it's anything but a sloped surface, turn around like normal
turn_around();
}
}

}

HitResponse
Expand Down
Loading