-
-
Notifications
You must be signed in to change notification settings - Fork 539
Add editor shortcuts for Tiles and Objects navigation (SuperTux#2988) #3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Did you attempt to merge all of master and stage it? You'll have to fix that, as it's difficult to review the code |
- Add "Q" to switch between Tiles and Objects; - Add Shift + "Q" to toggle between current and last subgroup inside the same group (Tiles or Objects); - Add Shift + Scroll to open the current menu and select on release; - Add "S" to open a menu of sub-subgroups within each Tiles subgroup; - This uses the divisions previously commented in tiles.strf. Co-authored-by: Afonso Mateus <[email protected]>
Yes, you are absolutely right. I think it's good now. |
I'm honestly not a fan of introducing more shortcuts to the editor unless a versatile solution is implemented which allows the user to bind each individual key to their wishes, and preferably most of them would be bound to |
In the meantime, I would still prefer to at least have some sort of shortcut, instead of postponing it to whenever you guys implement bind-able shortcuts. But, until then, why is adding more shortcuts an issue? Just convert them all when the time comes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the keybind for "S" to "G" instead? s overlaps with ctrl+s and WASD camera controls if you have your movement keybinds set to those.
@Frostwithasideofsalt, when adding custom tilesets, you still add them to your "tiles.strf", right? The problem I see there is that the menu now searches for "parent_group" and not "name". My guess would be that those tilesets don't have a defined parent_group in that file, which causes them to appear blank in the menu and not show the tiles when you select them. If that's the case, you just need to add something like "(parent_group (_ ""))" above the "(name (_ ""))". |
There really needs to be a fallback if it can't find a "parent_group" to ensure that all the old custom tilesets dont break. |
Ok. I'll do that. |
alright, thank you! |
- Fixed bugs: - The subgroup would still be selected when returning from it to the parent group. - Some tiles weren't selectable when showing the whole parent group. - When showing a subgroup, the scrollbar was set for the whole parent group. Co-authored-by: Afonso Mateus <[email protected]>
- Wrapped the text with the gettext translation function. - Added credits to the editor_tilesubgroup_menu files. Co-authored-by: Afonso Mateus <[email protected]>
Co-authored-by: Afonso Mateus [email protected]