Skip to content

Conversation

VaLLeX8
Copy link

@VaLLeX8 VaLLeX8 commented Jun 13, 2025

  • Add "Q" to switch between Tiles and Objects;
  • Add Shift + "Q" to toggle between current and last subgroup inside the same group (Tiles or Objects);
  • Add Shift + Scroll to open the current menu and select on release;
  • Add "S" to open a menu of sub-subgroups within each Tiles subgroup;
    • This uses the divisions previously commented in tiles.strf.

Co-authored-by: Afonso Mateus [email protected]

@swagtoy
Copy link
Collaborator

swagtoy commented Jun 13, 2025

Did you attempt to merge all of master and stage it? You'll have to fix that, as it's difficult to review the code

- Add "Q" to switch between Tiles and Objects;
- Add Shift + "Q" to toggle between current and last subgroup inside the same group (Tiles or Objects);
- Add Shift + Scroll to open the current menu and select on release;
- Add "S" to open a menu of sub-subgroups within each Tiles subgroup;
  - This uses the divisions previously commented in tiles.strf.

Co-authored-by: Afonso Mateus <[email protected]>
@VaLLeX8
Copy link
Author

VaLLeX8 commented Jun 13, 2025

Yes, you are absolutely right. I think it's good now.

@bruhmoent
Copy link
Member

I'm honestly not a fan of introducing more shortcuts to the editor unless a versatile solution is implemented which allows the user to bind each individual key to their wishes, and preferably most of them would be bound to none from the start. I find it confusing to have unknown bindings all over the keyboard which perform vastly different actions, and inconvenient.

@MatusGuy
Copy link
Contributor

In the meantime, I would still prefer to at least have some sort of shortcut, instead of postponing it to whenever you guys implement bind-able shortcuts.

But, until then, why is adding more shortcuts an issue? Just convert them all when the time comes...

Copy link
Member

@Frostwithasideofsalt Frostwithasideofsalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the keybind for "S" to "G" instead? s overlaps with ctrl+s and WASD camera controls if you have your movement keybinds set to those.

@Frostwithasideofsalt
Copy link
Member

apon further testing, this also seems to break all custom tilesets, alongside with breaking the "others" tile category. the broken tilemaps wont show their name, instead showing a empty space where the tilemap would be.
image
these broken tile-groups also contain no tiles in the editor.
image
any existing tiles from these groups still work in the levels, they just dont show up in the editor.

@VaLLeX8
Copy link
Author

VaLLeX8 commented Jun 18, 2025

@Frostwithasideofsalt, when adding custom tilesets, you still add them to your "tiles.strf", right? The problem I see there is that the menu now searches for "parent_group" and not "name". My guess would be that those tilesets don't have a defined parent_group in that file, which causes them to appear blank in the menu and not show the tiles when you select them. If that's the case, you just need to add something like "(parent_group (_ ""))" above the "(name (_ ""))".
If that doesn't solve the problem, please let me know—and thank you for taking a look at this.

@Frostwithasideofsalt
Copy link
Member

There really needs to be a fallback if it can't find a "parent_group" to ensure that all the old custom tilesets dont break.

@VaLLeX8
Copy link
Author

VaLLeX8 commented Jun 18, 2025

Ok. I'll do that.

@Frostwithasideofsalt
Copy link
Member

alright, thank you!

- Fixed bugs:
  - The subgroup would still be selected when returning from it to the parent group.
  - Some tiles weren't selectable when showing the whole parent group.
  - When showing a subgroup, the scrollbar was set for the whole parent group.

Co-authored-by: Afonso Mateus <[email protected]>
- Wrapped the text with the gettext translation function.
- Added credits to the editor_tilesubgroup_menu files.

Co-authored-by: Afonso Mateus <[email protected]>
@VaLLeX8 VaLLeX8 requested a review from tobbi July 2, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants