Fix autotile mode not updating from menu#3547
Open
Semphriss wants to merge 1 commit intoSuperTux:masterfrom
Open
Fix autotile mode not updating from menu#3547Semphriss wants to merge 1 commit intoSuperTux:masterfrom
Semphriss wants to merge 1 commit intoSuperTux:masterfrom
Conversation
Going in the Editor settings menu, toggling the autotile mode and leaving the menu using only the mouse (not the escape key) would not update the status until Ctrl is pressed again.
swagtoy
force-pushed
the
master
branch
2 times, most recently
from
806ca6a to
c12b71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going in the Editor settings menu, toggling the autotile mode and leaving the menu using only the mouse (not the escape key) would not update the status until Ctrl is pressed again.
I fixed this by making the overlay widget refresh immediately when the option changes using the callback implementation of the toggle option.
I'm not sure if this is the best fix possible, but it's a fix, so it can serve as a starting point should modifications be required.