Fix #3634: Fix profile menu not greying out after deleting all profiles#3754
Open
catzh23 wants to merge 1 commit intoSuperTux:masterfrom
Open
Fix #3634: Fix profile menu not greying out after deleting all profiles#3754catzh23 wants to merge 1 commit intoSuperTux:masterfrom
catzh23 wants to merge 1 commit intoSuperTux:masterfrom
Conversation
…l profiles When all profiles are deleted, the "Rename", "Reset" and "Delete" options in the profile menu remained active instead of being greyed out. This was caused by m_current_profile not being reset to nullptr after deletion, leaving a dangling pointer that made the menu think a profile was still selected. Fix by setting m_current_profile to nullptr before calling refresh() in both the "Delete" and "Delete all" callbacks. Closes SuperTux#3634
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all profiles are deleted, the "Rename", "Reset" and "Delete" options in the profile menu remained active instead of being greyed out. This was caused by m_current_profile not being reset to nullptr after deletion, leaving a dangling pointer that made the menu think a profile was still selected.
Fix by setting m_current_profile to nullptr before calling refresh() in both the "Delete" and "Delete all" callbacks.
Closes #3634