Fix #3659: Add fade-out when leaving Rooted Forest worldmap#3763
Open
Davi-Azeredo wants to merge 1 commit intoSuperTux:masterfrom
Open
Fix #3659: Add fade-out when leaving Rooted Forest worldmap#3763Davi-Azeredo wants to merge 1 commit intoSuperTux:masterfrom
Davi-Azeredo wants to merge 1 commit intoSuperTux:masterfrom
Conversation
The transition from Rooted Forest (world2) to Icy Island (world1) was missing a fade-out effect. Added a special-tile with Effect.fade_out() at position (23, 98) with apply-to-direction "north" (which triggers when the player moves southward) to match the behavior of all other world-to-world transitions. No automated tests are added because the project has no testing infrastructure for worldmap data files (.stwm). The existing test suite only covers C++ unit tests (see tests/unit/). The fix was verified manually by loading the game in developer mode and confirming the fade-out effect triggers correctly when transitioning from Rooted Forest to Icy Island, and that the reverse transition remains unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transition from Rooted Forest (world2) to Icy Island (world1) was missing a fade-out effect. Added a special-tile with Effect.fade_out() at position (23, 98) with apply-to-direction "north" (which triggers when the player moves southward) to match the behavior of all other world-to-world transitions.
No automated tests are added because the project has no testing infrastructure for worldmap data files (.stwm). The existing test suite only covers C++ unit tests (see tests/unit/). The fix was verified manually by loading the game in developer mode and confirming the fade-out effect triggers correctly when transitioning from Rooted Forest to Icy Island, and that the reverse transition remains unaffected.
Closes #3659