add basic directory tests#80
Conversation
commit: |
|
it's expected if it matches fast-glob. if it doesn't let me know and i'll fix it :) |
|
I think the tests should pass when using
My observations only consider directories, but should align for Also note that fast-glob does not suffix directories with |
|
tested, it's a regression on main (works on 0.2.10). thanks for reporting! would have been chaotic if this bug made its way into a release |
|
looks like the bug isn't present in #76, so should be fixed once that gets merged |
|
Splendid! Perhaps good to have tests to prevent regressions, the ones in this PR or others. Let me know, I'd be happy to refactor or add more. Or close this PR. |
|
yep, will merge this once the bug is fixed :) can you refactor them so that they don't create a new fixture? should be possible to use the already created one |
7adc53d to
882e3c7
Compare
|
of course! |
882e3c7 to
5fcc9c5
Compare
|
alright i did the thing :) |
When trying out tinyglobby, I noticed it doesn't return directories the way I'd expect. So I wonder whether using the single star like this is invalid syntax and expected behavior. Is there a way with different syntax and/or options to make the tests pass already?
Or should we try and make this happen? :)