Draft
Conversation
This change requires the app delegate and background app classes (or a factory to produce them) be provided before creating a launcher. This should (hopefully) allow us to add support for Google Dagger and Avaje inject.
This is still WIP, we need to migrate code to the (disabled) Avaje implementation module), add FXML support, etc.
FXML still not implemented.
FXML is working, but Avaje Hello Sample is a little clunky (with too many dependencies on the Avaje provider module) I'll checkpoint this now and plan to refactor and make better use (hopefully!) of Avaje, once I understand it better.
The minimal Supernaut and Avaje apps are now almost identical and the TestApp should probably work for Avaje unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.