forked from GrakovNe/lissen-android
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: Download enhancements #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 14 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3dae591
feat: Implement database migration to version 16 with a dedicated UI,…
9d0f06a
feat: Filter cached book queries to only include books that have at l…
71cbf62
feat: enhance cached items screen with storage statistics, detailed b…
01f3521
feat: introduce a new download modal with enhanced options for segmen…
714d9b2
feat: Allow subtitles to span two lines and refine download modal mon…
de72283
feat: Introduce `Queued` cache status, replace the shimmering downloa…
a106485
feat: enhance caching progress reporting with notification throttling…
41717a8
feat: Remove thumbnail cache clearing functionality and associated UI…
f936b5c
feat: Integrate Microsoft Clarity for analytics tracking and UI maski…
3a2ce89
feat: Implement analytics consent, overhaul persistent caching with d…
ecd3041
feat: Update CachedItemsSettingsScreen to navigate to the library whe…
331716d
feat: Implement bulk selection for cached items in settings, add meta…
dba6ec3
feat: Implement progressive image loading with blurred thumbnails, ad…
b8a4d87
Fix: Adjust `_preparingBookId` clearing to occur upon playback start …
684ec8c
feat: Optimize playback readiness by decoupling cover art updates, en…
5b66d4c
fix: forced server availability check, pull down to refresh, continue…
52c1e27
fix: show spinner for player buttons when the playback is being prepared
fc0fa44
fix: initial launch playback freeze by moving the exo player initiali…
74fc260
add changelog generation
826141a
Add update checker service
1b5bd36
fix book deletion glitch
cc16ea0
add code rabbit
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
Repository: SurjitSahoo/kahani-android
Length of output: 5795
🌐 Web query:
Microsoft Clarity Android SDK project ID configuration best practices💡 Result:
Best practices for configuring the Microsoft Clarity Android SDK Project ID
projectIdis the routing key that sends sessions to the correct Clarity project, so use separate Clarity projects (and IDs) per environment to avoid mixing data. [1]buildConfigField, productFlavors, or CI-injected values) and reference that constant when creatingClarityConfig(projectId = ...). This makes it easy to swap IDs per build variant while keeping initialization code identical. [1]Clarity.initialize(...)from the startup activityonCreate(); if you have multiple startup activities, initialize in a customApplicationclass or duplicate the call in each startup activity. [1]Verboselogging only for debugging. SetlogLevel = Verbosetemporarily to validate the integration, then disable (default isNone) for production builds. [1]Reference initialization (Kotlin):
(Initialization pattern per Microsoft docs. [1])
Sources: Android SDK installation docs [1], Mobile SDK getting started / Project settings overview [2].
[1] (learn.microsoft.com)
[2] (learn.microsoft.com)
Citations:
🏁 Script executed:
Repository: SurjitSahoo/kahani-android
Length of output: 546
🏁 Script executed:
Repository: SurjitSahoo/kahani-android
Length of output: 841
🏁 Script executed:
Repository: SurjitSahoo/kahani-android
Length of output: 324
Make CLARITY_PROJECT_ID configurable to support per-environment project IDs.
Microsoft Clarity best practices recommend storing the project ID in build-time configuration (not hardcoding), with support for environment variables and build flavors. This allows separate Clarity projects for different build variants while keeping initialization code identical.
The codebase already uses this pattern for signing credentials (lines 74, 82–84); apply the same approach here:
♻️ Suggested refactor
📝 Committable suggestion
🤖 Prompt for AI Agents