FEAT: Configurable session cookie max-age (0 = session-only)#1581
Open
WilberC wants to merge 2 commits intoSuwayomi:masterfrom
Open
FEAT: Configurable session cookie max-age (0 = session-only)#1581WilberC wants to merge 2 commits intoSuwayomi:masterfrom
WilberC wants to merge 2 commits intoSuwayomi:masterfrom
Conversation
- Added configuration for Jetty session cookie handling, allowing for persistent cookies based on the new `server.sessionCookieMaxAgeMinutes` setting. - Updated session inactivity timeout to extend from ~30 minutes to 30 days.
- Simplified Jetty session cookie handling by directly using the `sessionCookieMaxAgeMinutes` from the server configuration.
Syer10
requested changes
Aug 12, 2025
|
|
||
| # Sessions | ||
| # 0 = default session cookie behavior (no persistent Max-Age); >0 = persistent JSESSIONID with given max-age in minutes | ||
| server.sessionCookieMaxAgeMinutes = 0 |
Collaborator
There was a problem hiding this comment.
I would say put it under authentication and name it simpleAuthSessionCookieMaxAge, add a comment after it similar to the other comments
| val sessionHandler = context.sessionHandler ?: SessionHandler() | ||
| sessionHandler.sessionCookieConfig.apply { | ||
| val cookieMaxAgeMinutes: Int = serverConfig.sessionCookieMaxAgeMinutes.value | ||
| if (cookieMaxAgeMinutes > 0) maxAge = (cookieMaxAgeMinutes * 60) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (cookieMaxAgeMinutes > 0) maxAge = (cookieMaxAgeMinutes * 60) | |
| if (cookieMaxAgeMinutes > 0) maxAge = cookieMaxAgeMinutes.minutes.inWholeSeconds.toInt() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session cookie persistence
Overview
server.sessionCookieMaxAgeMinutescontrols the browser persistence of theJSESSIONIDcookie.Configure
Edit your
server.conf:0for session-only cookies.Restart the server to apply changes.
What changes
Set-Cookie: JSESSIONID; Max-Age=<minutes*60>; HttpOnly.Max-Ageis set (session cookie).Verify
server.conf, restart.0:Set-Cookie: JSESSIONIDhas noMax-Age.5: header includesMax-Age=300.Notes