Add chapter stats to MangaTable with GraphQL sort/filter support#1719
Open
everpcpc wants to merge 1 commit intoSuwayomi:masterfrom
Open
Add chapter stats to MangaTable with GraphQL sort/filter support#1719everpcpc wants to merge 1 commit intoSuwayomi:masterfrom
everpcpc wants to merge 1 commit intoSuwayomi:masterfrom
Conversation
… support - Add chaptersLastReadAt, chaptersLastUploadDate, chaptersUnreadCount, chaptersTotalCount to MangaTable - Support sorting and filtering these fields in GraphQL MangaQuery - Auto-update stats when chapters are fetched or modified - Add database migration M0053_AddMangaChapterStatsColumns
Collaborator
|
This should be done using joins and other database queries. It shouldn't be done by adding the columns to the manga table directly |
Author
|
Sorting with join queries can be very complex, especially for operations like count. The query efficiency will be very low and may greatly impact performance. |
Contributor
|
write both if the performance difference is substantial enough syer may change his mind |
Collaborator
|
Some test code I wrote a while ago to provide an example for the join kind of implementation. And for asCursor I won't mind if there are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related