Add IReader extension support to Suwayomi-Server by kazemcodes · Pull Request #1784 · Suwayomi/Suwayomi-Server

kazemcodes · 2025-11-12T11:56:57Z

Integrated IReader source-api (38 files) for novel/light novel reading
Created separate database tables for IReader extensions and sources
Implemented extension management (install, update, uninstall)
Added REST API endpoints under /api/v1/ireader/
Full parallel operation with existing Tachiyomi functionality
Zero breaking changes to existing code
Comprehensive documentation included

- Integrated IReader source-api (38 files) for novel/light novel reading - Created separate database tables for IReader extensions and sources - Implemented extension management (install, update, uninstall) - Added REST API endpoints under /api/v1/ireader/ - Full parallel operation with existing Tachiyomi functionality - Zero breaking changes to existing code - Comprehensive documentation included

- Add IReader source API interfaces (Source, CatalogSource, HttpSource, SourceFactory) - Implement IReader extension loading following Tachiyomi pattern - Add database tables for IReader extensions and sources - Add API controllers for IReader extensions and sources - Support loading IReader Android APKs via dex2jar conversion - Add extension management (install, uninstall, update) - Add IReader source listing and retrieval

Syer10 · 2025-11-12T12:40:12Z

Interesting, your are the dev of IReader? I'm not against novel support for Suwayomi.

A few notes to start with.

We do not support the REST api anymore, endpoints should be added under the GraphQL api in the GraphQL package
I saw quite a bit of duplicate code, especially with the extensions installer. There should be a way to deduplicate this code so that functions can be shared between Manga and Novel extension installers.
I saw a few expect functions and classes. Since we are a single platform program, there should be no expect/actual, just implementations.

- Fix deprecated -Xcontext-receivers to -Xcontext-parameters - Fix KtLint violations (package names, wildcard imports, file naming) - Add missing findInstance extension functions - Fix task dependencies in build.gradle.kts - Reorganize package structure (core_api -> coreapi) - Add comprehensive IReader documentation

kazemcodes · 2025-11-12T13:28:21Z

yes, I'm dev of IReader, I will try to fix the issue you mentioned,
by the way thanks for creating base implementation

… replaced with concrete JVM implementations.

…staller utility

kazemcodes · 2025-11-12T14:18:57Z

I complete all changes you mentioned

Interesting, your are the dev of IReader? I'm not against novel support for Suwayomi.

A few notes to start with.

We do not support the REST api anymore, endpoints should be added under the GraphQL api in the GraphQL package

I saw quite a bit of duplicate code, especially with the extensions installer. There should be a way to deduplicate this code so that functions can be shared between Manga and Novel extension installers.

I saw a few expect functions and classes. Since we are a single platform program, there should be no expect/actual, just implementations.

Syer10 · 2025-11-12T14:27:05Z

Its a start. I will do a more in-depth review when I have time.

The GraphQL parts are not complete but I can also tell you what's needed later.

Syer10

Initial round of review

server/src/main/kotlin/suwayomi/tachidesk/graphql/mutations/IReaderExtensionMutation.kt

Syer10 · 2025-11-13T16:19:20Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/queries/IReaderExtensionQuery.kt

+import suwayomi.tachidesk.server.JavalinSetup.future
+import java.util.concurrent.CompletableFuture
+
+class IReaderExtensionQuery {


This implementation is wrong, it should mimic the ExtensionQuery and ExtensionMutation classes.

Any query that changes the database needs to be a mutation, and (almost) all database tables should have a dedicated Query class.

This class still deviates quite a bit from the ExtensionQuery class. It doesn't implement proper sorting, filtering, and adds a bunch of useless queries. Change it to mimic the ExtensionQuery class

Syer10 · 2025-11-13T16:20:48Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/queries/IReaderNovelQuery.kt

+import suwayomi.tachidesk.server.JavalinSetup.future
+import java.util.concurrent.CompletableFuture
+
+class IReaderNovelQuery {


This is a group of mutations that should be split up into multiple several files, try to mimic the Manga side when creating these variants.

This is not mimicing the MangaQuery class.

can you check this file again, does it now meets you expectation now?

Much better

kazemcodes · 2025-11-14T13:59:31Z

I made some changes, when you had time check them out

Syer10

Round 2

server/src/main/kotlin/ireader/core/http/DefaultUserAgent.kt

server/src/main/kotlin/ireader/core/prefs/PreferenceStore.kt

server/src/main/kotlin/ireader/core/source/model/PageListEmpty.kt

server/src/main/kotlin/org/ireader/coreapi/prefs/PreferenceStore.kt

Syer10 · 2025-11-15T20:17:47Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/mutations/IReaderChapterMutation.kt

Why are we using a novelUrl instead of a database id?

The current design uses novelUrl because this mutation is intended for source-level browsing - fetching novel content directly from IReader sources without requiring the novel to be persisted in the database first. This allows users to preview content before adding novels to their library.

Syer10 · 2025-11-15T20:18:12Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/mutations/IReaderChapterMutation.kt

Why are we using a chapter url instead of a database id?

The current design uses chapterUrl because this mutation is intended for source-level browsing - fetching chapter content directly from IReader sources without requiring the chapter to be persisted in the database first. This allows users to preview content before adding novels to their library.

Syer10 · 2025-11-15T20:21:02Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/queries/IReaderNovelQuery.kt

+import suwayomi.tachidesk.server.JavalinSetup.future
+import java.util.concurrent.CompletableFuture
+
+class IReaderNovelQuery {


This is not mimicing the MangaQuery class.

server/src/main/kotlin/suwayomi/tachidesk/graphql/queries/IReaderSourceQuery.kt

server/src/main/kotlin/suwayomi/tachidesk/graphql/types/IReaderNovelTypes.kt

KolbyML · 2025-12-10T00:32:39Z

@kazemcodes this is cool, hope you continue

… Java

# Conflicts: # server/build.gradle.kts # server/src/main/kotlin/ireader/core/http/BrowserEngine.kt # server/src/main/kotlin/ireader/core/http/Exception.kt # server/src/main/kotlin/ireader/core/http/HttpClientExtJVM.kt # server/src/main/kotlin/ireader/core/http/HttpClients.kt # server/src/main/kotlin/ireader/core/http/JS.kt # server/src/main/kotlin/ireader/core/http/JSFactory.kt # server/src/main/kotlin/ireader/core/http/PersistentCookieStore.kt # server/src/main/kotlin/ireader/core/http/WebViewManger.kt # server/src/main/kotlin/ireader/core/http/WebViewUtil.kt # server/src/main/kotlin/ireader/core/log/Log.kt # server/src/main/kotlin/ireader/core/source/CatalogSource.kt # server/src/main/kotlin/ireader/core/source/ErrorHandling.kt # server/src/main/kotlin/ireader/core/source/Ext.kt # server/src/main/kotlin/ireader/core/source/HttpSource.kt # server/src/main/kotlin/ireader/core/source/ParsedHttpSource.kt # server/src/main/kotlin/ireader/core/source/ParsingUtils.kt # server/src/main/kotlin/ireader/core/source/Source.kt # server/src/main/kotlin/ireader/core/source/SourceFactory.kt # server/src/main/kotlin/ireader/core/source/model/ChapterInfo.kt # server/src/main/kotlin/ireader/core/source/model/Command.kt # server/src/main/kotlin/ireader/core/source/model/Filter.kt # server/src/main/kotlin/ireader/core/source/model/FilterList.kt # server/src/main/kotlin/ireader/core/source/model/MangasPageInfo.kt # server/src/main/kotlin/ireader/core/source/model/Page.kt # server/src/main/kotlin/ireader/core/util/CoroutineExt.kt # server/src/main/kotlin/suwayomi/tachidesk/manga/MangaAPI.kt # server/src/main/kotlin/suwayomi/tachidesk/manga/impl/IReaderSource.kt # server/src/main/kotlin/suwayomi/tachidesk/manga/impl/extension/ireader/IReaderExtension.kt # server/src/main/kotlin/suwayomi/tachidesk/manga/impl/extension/ireader/IReaderExtensionsList.kt # server/src/main/kotlin/suwayomi/tachidesk/manga/impl/extension/ireader/IReaderGithubApi.kt

… Java

kazemcodes · 2025-12-10T20:49:15Z

Looking at the recent options, I think you got hit by the dex2jar update. You can probably remove a lot of that code by adding this to the dex2jar runner.

Suwayomi-Server/server/src/main/kotlin/suwayomi/tachidesk/manga/impl/util/PackageTools.kt

Line 70 in 817589f

.dontSanitizeNames(true)

Unless you are referencing another dex2jar issue.

there is another problem with dex2jar
this is an answer from claude opus 4.5 model
"The .dontSanitizeNames(true) is already present. The stackmap frame issue is a fundamental problem with how dex2jar converts Dalvik bytecode to JVM bytecode - it doesn't always generate correct stackmap frames for complex control flow (especially Kotlin coroutines)."

kazemcodes · 2025-12-10T20:49:58Z

I think the issue is with coroutines current versions, there seems to be some problem with it, not sure, it works fine before with any issue without flag, but after I updated the my source-api module in order to create even better sources, this bug happens here ,
I decided to recode the source in something better than orginal tachi sources which handles cloudflare, ratelimit, and other stuff better

Syer10 · 2025-12-11T04:22:28Z

Try making sure the extensions don't include any dependencies in its apks. Use the Android Studio APK explorer. For example when I implemented Apollo in the Suwayomi extension it pulled in other dependencies that conflicted with the apps dependencies.
https://github.com/Suwayomi/tachiyomi-extension/blob/769c2d3b2412fc3ddb50d5a479f418215dedfd6d/src/all/tachidesk/build.gradle#L30

Otherwise that verify error sounds familiar, but I forget where.

kazemcodes · 2025-12-11T06:48:13Z

Try making sure the extensions don't include any dependencies in its apks. Use the Android Studio APK explorer. For example when I implemented Apollo in the Suwayomi extension it pulled in other dependencies that conflicted with the apps dependencies.
https://github.com/Suwayomi/tachiyomi-extension/blob/769c2d3b2412fc3ddb50d5a479f418215dedfd6d/src/all/tachidesk/build.gradle#L30

Otherwise that verify error sounds familiar, but I forget where.

I will try to find a solution for this problem

Syer10 · 2025-12-11T06:56:22Z

I think I remember where I encountered that error before.
Keiyoushi once tested enabling proguard for the extensions but it caused the verify exception that you are talking about in Suwayomi, so it was decided not to do it and leave proguard off.

kazemcodes · 2025-12-12T17:31:28Z

I think I remember where I encountered that error before. Keiyoushi once tested enabling proguard for the extensions but it caused the verify exception that you are talking about in Suwayomi, so it was decided not to do it and leave proguard off.

I tried multiple ways to fix this issue, and after trying every thing,I decided to not use dex2jar at all, directly using .jar files that main ireader-extensions repo create ,
the problem wasn't even in proguard rule as extensions is not using proguard rules at all, jar are faster to use in jvm

kazemcodes · 2025-12-12T17:43:15Z

can you recheck the new file changes, I almost resolved all things you mentioned

Syer10 · 2025-12-15T16:49:00Z

local.properties

This file shouldn't be added to the repo.

gradle/libs.versions.toml

server/src/main/kotlin/ireader/core/http/CookieManager.kt

server/src/main/kotlin/ireader/core/http/CookieSynchronizer.kt

Syer10 · 2025-12-15T17:24:47Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/mutations/IReaderSourceMutation.kt

These novels need to be in the database at this point. We cannot serve data that is not saved. They also need database ids so that we can use them later.

Syer10 · 2025-12-15T17:25:18Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/mutations/IReaderSourceMutation.kt

These chapters need to be in the database at this point. We cannot serve data that is not saved. They also need database ids so that we can use them later.

Syer10 · 2025-12-15T17:25:35Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/queries/IReaderNovelQuery.kt

+import suwayomi.tachidesk.server.JavalinSetup.future
+import java.util.concurrent.CompletableFuture
+
+class IReaderNovelQuery {


Much better

Syer10 · 2025-12-15T17:26:46Z

server/src/main/kotlin/suwayomi/tachidesk/graphql/types/IReaderNovelTypes.kt

+data class IReaderChapterType(
+    val name: String,
+    val key: String,
+    val dateUpload: Long,
+    val number: Float,
+    val scanlator: String,
+) {
+    constructor(chapterInfo: ChapterInfo) : this(
+        name = chapterInfo.name,
+        key = chapterInfo.key,
+        dateUpload = chapterInfo.dateUpload,
+        number = chapterInfo.number,
+        scanlator = chapterInfo.scanlator,
+    )
+}


Chapters should be in the database

server/src/main/kotlin/suwayomi/tachidesk/manga/MangaAPI.kt

kazemcodes · 2025-12-15T18:02:01Z

Thanks for review, I will fix the issue you mentioned later

kazemcodes · 2025-12-21T09:25:37Z

Any more issues?

Syer10 · 2025-12-21T15:37:10Z

There is still a bunch of comments that need to be addressed from my previous review

sohilsayed · 2026-01-16T20:49:16Z

Really looking forward for this
Keep up the good work @kazemcodes

kaihouguide · 2026-01-17T05:12:53Z

yo this is hype really waiting for LN support and maybe anime if possible it'd be the ultimate all in 1 app

kazemcodes added 4 commits November 11, 2025 21:37

implement and tesst IReader integration

66beb60

adding files

06adf31

kazemcodes added 2 commits November 12, 2025 16:28

fix klint workflow error

f323a97

kazemcodes added 3 commits November 12, 2025 17:04

All the expect/actual declarations have been successfully removed and…

dff708c

… replaced with concrete JVM implementations.

migrate to GraphQL

8825dfb

Extension.kt and IReaderExtension.kt integrate the shared ExtensionIn…

245af7b

…staller utility

reformat my code for klint

a39cc7c

kazemcodes added 3 commits November 12, 2025 18:00

add primary key constraint

e66a6e0

improve GraphQL

62010d0

fix db migration

b35e2fd

Syer10 requested changes Nov 13, 2025

View reviewed changes

fix code base on reviews

accb7d9

kazemcodes requested a review from Syer10 November 15, 2025 15:45

Syer10 requested changes Nov 15, 2025

View reviewed changes

kazemcodes added 7 commits December 10, 2025 21:14

update source-api

e8fadef

update apis

26e3ee8

update github

3c7c599

now it works

e23527a

add jvm ignore flag because kotlin jvm compiled jar is different from…

19d9a9d

… Java

add jvm ignore flag because kotlin jvm compiled jar is different from…

34d34af

… Java

kazemcodes and others added 2 commits December 11, 2025 00:12

feat: update user agent handling

b1b848e

Merge branch 'master' into ireader-integration

0902996

kazemcodes added 2 commits December 11, 2025 00:32

refactor(GraphQL): move IReader from mutation to query

dc05f26

refactor: improve IReader GraphQL API

a0c060a

kazemcodes added 5 commits December 12, 2025 19:21

update preference store to use SharedPreferences instead of JVM pref

f3919c3

use jar files instead of apk to bypass dex2jar issue verfiy error in jvm

a80dc16

revert git ignore files to original one

5ba43d2

clean up codes

63e0b13

IReader Cloudflare Bypass Integration with Tachidesk

5f14df6

provide using both db id, and legacy novelurl in saving novels in db

a80f952

kazemcodes requested a review from Syer10 December 12, 2025 18:53

Syer10 requested changes Dec 15, 2025

View reviewed changes

kazemcodes added 5 commits December 15, 2025 23:14

refactor: remove IReader REST API and core http classes

ee57b91

fix(ireader): enable source configuration and sync user agent

0c4d6c2

feat: add IReader source preferences to GraphQL

a5ca676

feat: add IReader download and backup support

9a9ef78

fix: handle IReaderNovel status as Int

c02edaf

kazemcodes requested a review from Syer10 December 15, 2025 20:22

Conversation

kazemcodes commented Nov 12, 2025

Uh oh!

Syer10 commented Nov 12, 2025

Uh oh!

kazemcodes commented Nov 12, 2025

Uh oh!

kazemcodes commented Nov 12, 2025

Uh oh!

Syer10 commented Nov 12, 2025

Uh oh!

Syer10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kazemcodes commented Nov 14, 2025

Uh oh!

Syer10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

KolbyML commented Dec 10, 2025

Uh oh!

kazemcodes commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kazemcodes commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Syer10 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kazemcodes commented Dec 11, 2025

Uh oh!

Syer10 commented Dec 11, 2025

Uh oh!

kazemcodes commented Dec 12, 2025

Uh oh!

kazemcodes commented Dec 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

kazemcodes commented Dec 10, 2025 •

edited

Loading

kazemcodes commented Dec 10, 2025 •

edited

Loading

Syer10 commented Dec 11, 2025 •

edited

Loading

kaihouguide commented Jan 17, 2026 •

edited

Loading