Open
Conversation
Syer10
requested changes
Jan 26, 2026
Collaborator
Syer10
left a comment
Syer10
left a comment
There was a problem hiding this comment.
Meta for Source, Anime, and Episodes are needed.
Also what is the status of categories?
Comment on lines
+20
to
+21
| AnimeExtensionTable, | ||
| AnimeSourceTable, |
Collaborator
There was a problem hiding this comment.
Use one-time use table classes. Referencing the actual tables will break the migrations if they are ever changed. See other migrations that add tables for examples
Collaborator
There was a problem hiding this comment.
Combine all the migrations
| import suwayomi.tachidesk.anime.controller.SourceController | ||
|
|
||
| object AnimeAPI { | ||
| fun defineEndpoints() { |
Collaborator
There was a problem hiding this comment.
Don't add REST endpoints unless they are actually needed, like for icons, thumbnails, and the video proxy. Everything that can be should be done in GQL.
Comment on lines
+78
to
+79
| .readTimeout(2, TimeUnit.MINUTES) | ||
| .callTimeout(5, TimeUnit.MINUTES) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.