Fix memory leak on frame observer#141
Merged
SvenTiigi merged 1 commit intoSvenTiigi:developfrom Oct 15, 2025
Merged
Conversation
Owner
|
LGTM 👍 |
Owner
|
Changes are available with the latest release 2.0.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋
This PR addresses a memory leak (see #37 [and maybe #131]) caused by a strong capture of
YouTubePlayerWebViewinside itsframeChangesCancellable. Weakifyingselfinside theTaskhad no effect, since the view was already strongly captured by thesink, preventing proper deallocation of theNSKVOObserverandWebViewitself.In practice, this will cause the player to leak and, if the player is closed before the video starts, audio might continue playing in the background with no way to stop it.
This change weakens the self capture in sink to ensure proper cleanup.