-
Notifications
You must be signed in to change notification settings - Fork 184
feat: nested media usage #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: nested media usage #1368
Conversation
Summary of ChangesHello @Zeyi-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant feature that enhances the flexibility of SwanLab's media logging capabilities by enabling 'nested media usage'. Users can now instantiate various media types (Audio, Image, Molecule, Text, Video) by providing an existing instance of the same media type. This allows for convenient manipulation, such as updating captions or resizing images, without needing to re-supply the raw data, thereby streamlining the logging workflow and improving API usability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for nested media object creation, such as swanlab.Image(swanlab.Image(data)), across various media types including Audio, Image, Text, Video, Molecule, and Object3D. The changes are accompanied by new unit tests. While the overall implementation is good, I've identified a significant bug in Object3D's handling of nested types, some inconsistencies in the Audio class, and opportunities for code improvement in Molecule and Video classes.
Description
Closes: #1367