Merge pull request #191 from SwiftFiddle/refactor3

Refactor

Author: kishikawakatsumi

Public/css/popover.css

@@ -39,7 +39,7 @@
 
 .popover-content dt {
   padding: 0 8px;
-  background-color: #f2f2f2;
+  background-color: #f5f5f5;
   font-family: Menlo, Consolas, "DejaVu Sans Mono", "Ubuntu Mono", monospace;
 }
 

Public/js/structure_view.js

@@ -64,31 +64,9 @@ function makeSyntaxPopoverContent(data) {
   const title = document.createElement("div");
   title.classList.add("title");
   title.innerText = `${data.text}Syntax`;
-  container.appendChild(title);
+  title.appendChild(makeSyntaxTypeBadge(data.type));
 
-  const label = document.createElement("span");
-  label.classList.add("badge", "text-bg-light");
-  switch (data.type) {
-    case "decl": {
-      label.innerText = "DeclSyntax";
-      break;
-    }
-    case "expr": {
-      label.innerText = "ExprSyntax";
-      break;
-    }
-    case "pattern": {
-      label.innerText = "PatternSyntax";
-      break;
-    }
-    case "type": {
-      label.innerText = "TypeSyntax";
-      break;
-    }
-    default:
-      break;
-  }
-  title.appendChild(label);
+  container.appendChild(title);
 
   const dl = document.createElement("dl");
 
@@ -165,6 +143,32 @@ function makeDescriptionList(term, details, list) {
   list.appendChild(dd);
 }
 
+function makeSyntaxTypeBadge(type) {
+  const badge = document.createElement("span");
+  badge.classList.add("badge", "text-bg-light");
+  switch (type) {
+    case "decl": {
+      badge.innerText = "DeclSyntax";
+      break;
+    }
+    case "expr": {
+      badge.innerText = "ExprSyntax";
+      break;
+    }
+    case "pattern": {
+      badge.innerText = "PatternSyntax";
+      break;
+    }
+    case "type": {
+      badge.innerText = "TypeSyntax";
+      break;
+    }
+    default:
+      break;
+  }
+  return badge;
+}
+
 function stripHTMLTag(text) {
   const div = document.createElement("div");
   div.innerHTML = text

Public/js/tree_view.js

@@ -160,8 +160,6 @@ export class TreeView {
   }
 }
 
-function onMouseover(event, target, parent) {}
-
 function makeDownCaret() {
   const caret = document.createElement("span");
   caret.classList.add(