SwiftOVATE · dependabot-pr · Feb 8, 2023 · Feb 8, 2023
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-app",
-  "homepage": "https://pratikkabade.github.io/Github-Portfolio/",
+  "homepage": "https://pratikkabade.github.io/github-portfolio/",
   "version": "0.1.0",
   "description": "Built from https://www.github.com/firenudge-io/",
   "private": true,

diff --git a/public/index.html b/public/index.html
@@ -3,11 +3,10 @@
 
 <head>
   <meta charset="utf-8" />
-  <link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
   <meta name="viewport" content="width=device-width, initial-scale=1" />
   <meta name="theme-color" content="#000000" />
   <meta name="description" content="Web site created using create-react-app" />
-  <title>Github Portfolio</title>
+  <title>My Portfolio</title>
   <!-- Bootstrap -->
   <link href='https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css' rel='stylesheet'
     integrity='sha384-0evHe/X+R7YkIZDRvuzKMRqM+OrBnVFBL6DOitfPri4tjfHxaWutUpFmBp4vmVor' crossorigin='anonymous' />

diff --git a/src/App.tsx b/src/App.tsx
@@ -6,7 +6,6 @@ import { AppRoutes } from './routes/Routes';
 function App() {
   return (
     <div className='App'>
-      {/* <Header /> */}
       <AppRoutes />
     </div>
   );

diff --git a/src/components/Header.tsx b/src/components/Header.tsx
diff --git a/src/components/home/OrganizationList.tsx b/src/components/home/OrganizationList.tsx
@@ -7,7 +7,7 @@ export const OrganizationList = () => {
         const ORG = data.map((item: any) => {
             return (
                 <div className="col-6 col-md-12 col-lg-6 col-xl-4 mb-3 orgs" key={item.id}>
-                    <a href={"org/" + item.login} className="github-component position-relative hover-grow height-full no-underline d-flex flex-column flex-justify-center text-center border border-gray-light rounded-1 bg-white p-5">
+                    <a rel="noreferrer" href={"/github-portfolio/org/" + item.login} className="github-component position-relative hover-grow height-full no-underline d-flex flex-column flex-justify-center text-center border border-gray-light rounded-1 bg-white p-5">
                         <img src={item.avatar_url} width={64} height={64} className="mx-auto rounded-1 mb-3" alt="avatar_url" />
                         <p className="f3 lh-condensed text-center gray-dark mb-0 mt-1">
                             {item.login}

diff --git a/src/components/home/Profile.tsx b/src/components/home/Profile.tsx
@@ -28,18 +28,25 @@ export const Profile = () => {
     }
     image()
 
+    // set avatar as page icon
+    const icon = document.querySelector("link[rel*='icon']") as HTMLLinkElement;
+
+    //  <link rel='icon' href='https://avatars.githubusercontent.com/u/108847584?s=200&v=4' />
+    if (icon) {
+        icon.href = avatar;
+    }
 
     return (
         <div className="flex-self-stretch border-md-right border-gray-light bg-white col-md-5 col-lg-4 col-xl-3 px-4 px-md-6 px-lg-7 py-6">
-            <img src={avatar} className="circle mb-3" style={{ maxWidth: 150 }} />
+            <img src={avatar} className="circle mb-3" style={{ maxWidth: 150 }} alt="avatar"/>
             <h1 className=" mb-2 lh-condensed">
                 {name}
             </h1>
             <p className="mb-3 f4 text-gray">{bio}
             </p>
             <div className="f4 mb-6">
                 {/* Github */}
-                <a href={url} target="_blank">
+                <a href={url} rel="noreferrer" target="_blank">
                     <div className="d-flex flex-items-center mb-3">
                         <svg height={20} className="octicon octicon-mark-github mr-2 v-align-middle" fill="#24292e" aria-label="GitHub" viewBox="0 0 16 16" version="1.1" width={20} role="img"><path fillRule="evenodd" d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0016 8c0-4.42-3.58-8-8-8z" /></svg>
                         @{UserName}
@@ -49,7 +56,7 @@ export const Profile = () => {
                 {/* Twitter */}
                 {
                     twitter !== null ?
-                        <a href={twitterUrl} target="_blank">
+                        <a href={twitterUrl} rel="noreferrer" target="_blank">
                             <div className="d-flex flex-items-center mb-3 ">
                                 <img height={20} className="octicon octicon-location mr-2 v-align-middle" src="https://raw.githubusercontent.com/dependabot-pr/Static-Files/main/Assets/Logo/Twitter.svg" alt="twitter" />
                                 {twitter}
@@ -67,9 +74,9 @@ export const Profile = () => {
                 {/* Email */}
                 {
                     email !== null ?
-                        <a href={"mailto:" + email} target="_blank">
+                        <a href={"mailto:" + email} rel="noreferrer" target="_blank">
                             <div className="d-flex flex-items-center mb-3 ">
-                                <img height={20} className="octicon octicon-location mr-2 v-align-middle" src="https://raw.githubusercontent.com/dependabot-pr/Static-Files/main/Assets/Logo/Google.svg" alt="mail" />
+                                <img height={20} className="octicon octicon-location mr-2 v-align-middle" src="https://raw.githubusercontent.com/dependabot-pr/Static-Files/main/Assets/Logo/Mail.svg" alt="mail" />
                                 {email}
                             </div>
                         </a>

diff --git a/src/components/org/Profile.tsx b/src/components/org/Profile.tsx
@@ -25,18 +25,26 @@ export const Profile = () => {
     }
     image()
 
+    // set avatar as page icon
+    const icon = document.querySelector("link[rel*='icon']") as HTMLLinkElement;
+
+    //  <link rel='icon' href='https://avatars.githubusercontent.com/u/108847584?s=200&v=4' />
+    if (icon) {
+        icon.href = avatar;
+    }
+
 
     return (
         <div className="flex-self-stretch border-md-right border-gray-light bg-white col-md-5 col-lg-4 col-xl-3 px-4 px-md-6 px-lg-7 py-6">
-            <img src={avatar} className="circle mb-3" style={{ maxWidth: 150 }} />
+            <img src={avatar} className="circle mb-3" style={{ maxWidth: 150 }} alt="avatar" />
             <h1 className=" mb-2 lh-condensed">
                 {name}
             </h1>
             <p className="mb-3 f4 text-gray">{bio}
             </p>
             <div className="f4 mb-6">
                 {/* Github */}
-                <a href={url} target="_blank">
+                <a href={url} target="_blank" rel="noreferrer">
                     <div className="d-flex flex-items-center mb-3">
                         <svg height={20} className="octicon octicon-mark-github mr-2 v-align-middle" fill="#24292e" aria-label="GitHub" viewBox="0 0 16 16" version="1.1" width={20} role="img"><path fillRule="evenodd" d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0016 8c0-4.42-3.58-8-8-8z" /></svg>
                         @{name}
@@ -46,7 +54,7 @@ export const Profile = () => {
                 {/* Email */}
                 {
                     email !== null ?
-                        <a href={"mailto:" + email} target="_blank">
+                        <a href={"mailto:" + email} target="_blank" rel="noreferrer">
                             <div className="d-flex flex-items-center mb-3 ">
                                 <img height={20} className="octicon octicon-location mr-2 v-align-middle" src="https://raw.githubusercontent.com/dependabot-pr/Static-Files/main/Assets/Logo/Google.svg" alt="mail" />
                                 {email}
@@ -57,7 +65,7 @@ export const Profile = () => {
                 <div className="d-flex flex-items-center mb-3 ">
 
                     {/* go back */}
-                    <a href="/Github-Portfolio" className="btn btn-outline">
+                    <a href="/github-portfolio" className="btn btn-outline">
                         Back
                     </a>
 

diff --git a/src/routes/Routes.tsx b/src/routes/Routes.tsx
@@ -8,9 +8,9 @@ export const AppRoutes = () => {
         <div>
             <BrowserRouter>
                 <Routes>
-                    <Route path="/Github-Portfolio" element={<Home />} />
-                    <Route path="/Github-Portfolio/org/*" element={<Organization />} />
-                    <Route path="/org/*" element={<Organization />} />
+                    <Route path="/" element={<Home />} />
+                    <Route path="/github-portfolio" element={<Home />} />
+                    <Route path="/github-portfolio/org/*" element={<Organization />} />
                 </Routes>
             </BrowserRouter>
         </div>