Skip to content

Bring back comment on BuildShow page #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Bring back comment on BuildShow page #3370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/App/Views/PackageController/Builds/BuildShow+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ enum BuildShow {
"Compatibility information for \(model.packageName). Check compatibility with \(model.buildInfo.swiftVersion.longDisplayName) on \(model.buildInfo.platform.displayName) with full build logs."
}

override func bodyComments() -> Node<HTML.BodyContext> {
.comment(model.versionId.uuidString)
}

override func frontEndDebugPanelData() -> [PublicPage.FrontEndDebugPanelDataItem] {
[
.init(title: "Version ID", value: model.versionId.uuidString)
Expand Down
2 changes: 1 addition & 1 deletion Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_BuildShow.1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<script src="/main.js?test" data-turbolinks-track="reload" defer></script><script async defer data-domain="swiftpackageindex.com" src="https://plausible.io/js/plausible.outbound-links.js"></script>
<script>window.plausible = window.plausible || function() { (window.plausible.q = window.plausible.q || []).push(arguments) }</script>
</head>
<body>
<body><!--CAFECAFE-CAFE-CAFE-CAFE-CAFECAFECAFE-->
<header>
<div class="inner">
<a href="/">
Expand Down
Loading