Skip to content

Conversation

daveverwer
Copy link
Member

Putting this in as a PR now, ahead of the work that @rahafjrw is doing on #3384. Mainly because there may be some discussion about rolling back the Soto change which I’d like to get out of the way before the first of the auth PRs land.

This rolls Soto back to 6.x due to the dependency in https://swiftpackageindex.com/soto-project/soto-cognito-authentication-kit 4.x. It undoes the change made in https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/pull/3207/files#diff-5d2ca8674645a1e92a14b68d5cc308c427c2d58120392a0df74d6a4f5fc97440.

There is a beta version of soto-cognito-authentication-kit in development, but it is not yet released. I chatted with @adam-fowler this afternoon and apparently the hold up on that beta is the dependency on the beta version of jwt-kit which is currently in RC.

It’s unlikely all of these will shake out before the authentication feature is finalised, but they also should not hold us on 6.x for very long since all of the dependencies have a RC status at the moment.

@adam-fowler
Copy link

If you ever feel the need there is a v5 beta of soto-cognito-authentication out now. https://github.com/vapor-community/soto-cognito-authentication/releases/tag/5.0.0-beta.1. But it'd need you to upgrade to the jwt-kit v5 release candidate

@daveverwer daveverwer merged commit f0c425a into main Sep 19, 2024
5 checks passed
@daveverwer daveverwer deleted the add-soto-cognito branch September 19, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants