Explore using swift dependencies #3399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
force-pushed
the
explore-using-swift-dependencies
branch
4 times, most recently
from
f906704 to
b0a00fc
Compare
|
There was a better solution and also a lurking problem due to escaping closure but both are fixed now, thanks to the help by the Pointfree folks. |
finestructure
force-pushed
the
explore-using-swift-dependencies
branch
from
a2b074a to
0a9b28f
Compare
|
Best review this with the "Hide whitespace" option ticked! |
finestructure
force-pushed
the
explore-using-swift-dependencies
branch
from
0a9b28f to
9352c47
Compare
daveverwer
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we'll want to start switching over, provided we find a solution for the problem of adding
@Dependencyproperties toCodabletypes.I've opened a discussion on the swift-dependencies repo to see if there's better solution that the three that I can think of.