Skip to content

Update custom collection page title #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update custom collection page title #3495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/App/Views/CustomCollection/CustomCollectionShow+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ enum CustomCollectionShow {
}

override func pageTitle() -> String? {
"Packages for collection \(model.name)"
"\(model.name) package collection"
}

override func pageDescription() -> String? {
Expand All @@ -46,7 +46,7 @@ enum CustomCollectionShow {
.group(
.h2(
.class("trimmed"),
.text("Packages for collection “\(model.name)”")
.text("\(model.name) package collection")
),
.p(
.text("These packages are available as a package collection, "),
Expand Down
8 changes: 4 additions & 4 deletions Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_CustomCollectionShow.1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
<link rel="canonical" href="http://localhost:8080/"/>
<meta name="twitter:url" content="http://localhost:8080/"/>
<meta property="og:url" content="http://localhost:8080/"/>
<title>Packages for collection Custom Collection &ndash; Swift Package Index</title>
<meta name="twitter:title" content="Packages for collection Custom Collection &ndash; Swift Package Index"/>
<meta property="og:title" content="Packages for collection Custom Collection &ndash; Swift Package Index"/>
<title>Custom Collection package collection &ndash; Swift Package Index</title>
<meta name="twitter:title" content="Custom Collection package collection &ndash; Swift Package Index"/>
<meta property="og:title" content="Custom Collection package collection &ndash; Swift Package Index"/>
<meta name="description" content="The Swift Package Index is indexing 5 packages for collection Custom Collection."/>
<meta name="twitter:description" content="The Swift Package Index is indexing 5 packages for collection Custom Collection."/>
<meta property="og:description" content="The Swift Package Index is indexing 5 packages for collection Custom Collection."/>
Expand Down Expand Up @@ -82,7 +82,7 @@ <h1>
</nav>
<main>
<div class="inner">
<h2 class="trimmed">Packages for collection “Custom Collection”</h2>
<h2 class="trimmed">Custom Collection package collection</h2>
<p>These packages are available as a package collection,
<a href="/package-collections">usable in Xcode 13 or the Swift Package Manager 5.5</a>.
</p>
Expand Down
Loading