Issue 3469 dependency transition 12 #3568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveverwer
approved these changes
Dec 29, 2024
finestructure
commented
Dec 29, 2024
|
|
||
| // NB: _testEncodedURL is a callback that exists purely to be able to regression test the encoded value | ||
| static func post(client: Client, message: String, _testEncodedURL: (String) -> Void = { _ in }) async throws { | ||
| static func apiURL(with message: String) throws -> String { |
There was a problem hiding this comment.
This change allowed us to get rid of this ugly hack with the trailing closure that was purely used for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the obsolete
httpClientfromAppEnvironmentand movesmastodonPostfromEnvironmentClienttoHTTPClient.I've confirmed that posting (and encoding) works as expected via our test account: