-
-
Notifications
You must be signed in to change notification settings - Fork 50
Add redis cache #3579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redis cache #3579
Conversation
I'll ad hoc deploy this from the branch to see how it goes in dev. |
REDIS_ARGS: '--maxmemory 4GB --maxmemory-policy allkeys-lru' | ||
ports: | ||
- '6379:6379' | ||
- '8001:8001' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to clarify the situation around the ports before deploying this in prod. I don't think they're open due to the firewall sitting in front of it but it needs double checking.
We should be able to connect to the 8001 port for the insights GUI via an ssh tunnel/port forward. I did that i the past but not in a while - need to dig up the commands again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it’s a swarm, there may need to be firewalls opened between the hosts - I don’t think it’s available in prod based on the current network security groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the swarm hosts are in the same NSG and I'm pretty sure we only need to open 8001 (to Bastion) in case we want to use the Redis GUI.
I've verified that this is working as intended on dev (which is technically also a swarm albeit with just one node).
Having some trouble getting this to work with service order. I suspect I think I know how to fix this but I'll leave it until tomorrow. |
did some reading when I got settled, and depends_on without a health check only verified start order, as you presumed. I found this example of using a CLI heathcheck for redis: redis: |
4d8466c
to
8371d00
Compare
Ok, this is now working:
The issue was that And using just That'd be fixable but I've simply worked around it by putting the temporary test write in a We won't really have to worry about launch order for the real deployment so this is a non-issue. |
networks: | ||
- backend | ||
networks: | ||
- backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alerting:
section was indented with 4 spaces rather than 2 spaces like the rest.
This reverts commit c38e729.
6ade103
to
e4ae483
Compare
Adds a redis service to
app.yml
.