-
-
Notifications
You must be signed in to change notification settings - Fork 50
adding redis to local development #3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's hold off on this, Joe. I'm preparing a first "real" use of Redis for our current documentation reference cache. This sets up the infrastructure needed (although it's quite tied to this particular use case for the moment - for example, the nested |
Sorry, I just realised I misread the point of this PR, see my comment here: #3582 (comment) I think all we need to do is weave the |
app.yml
Outdated
TWITTER_API_SECRET: ${TWITTER_API_SECRET} | ||
TWITTER_ACCESS_TOKEN_KEY: ${TWITTER_ACCESS_TOKEN_KEY} | ||
TWITTER_ACCESS_TOKEN_SECRET: ${TWITTER_ACCESS_TOKEN_SECRET} | ||
REDIS_HOST: ${REDIS_HOST} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We keep this list in alphabetical order to make it easier to confirm keys are present!
First day I've been able to have any mental capacity to catch back up. Updated this PR to work over the |
|
04f4f09
to
8a752fa
Compare
Apologies for the delay Joe, I completely lost track of this one! |
We should also add something to the |
I may be "jumping the gun" here- but wanted to explore poking at redis locally to work out the middleware using it.
With this in place, I was able to spin up the local environment on my machine in docker, with an additional local redis instance exposed on 6379 localhost.