Simplify LoggerClient implementation #3672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May have to abandon this for now. For some reason this works locally, on both macOS and Linux (arm), but fails in CI, even if I run it on an arm GH runner. I can't think of anything that's different. It did fail locally at one point but not anymore. Might try and reset tomorrow. The change isn't critical but it's a nice simplification that'll get rid of cruft and ensure the logger is set up exactly once. So it's worth having but not at any cost. |
daveverwer
approved these changes
Feb 25, 2025
2 tasks
|
Closing in favour of #3729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I can't reopen #3667 . Reproducing it here:
The
prepareDependenciesmechanism that's built into swift-dependencies actually does pretty much what I baked intoLoggerClient.To do: