Parallelise tests #3749
Merged
Parallelise tests #3749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
force-pushed
the
parallelise-tests-6
branch
from
67d82fc to
f3ec4ad
Compare
finestructure
commented
Apr 6, 2025
|
|
||
| test: xcbeautify | ||
| set -o pipefail \ | ||
| && swift test --disable-automatic-resolution --sanitize=thread --no-parallel \ |
There was a problem hiding this comment.
We have to drop TSan again, it keeps triggering when tests are run in parallel. It doesn't seem to be in code directly, it's in NIO. I don't think it's misuse on our end and I can't imagine it's a NIO problem, so perhaps a false positive.
finestructure
force-pushed
the
parallelise-tests-6
branch
from
f3ec4ad to
b67a33d
Compare
daveverwer
approved these changes
Apr 6, 2025
# Conflicts: # Tests/AppTests/Helpers/TestSupport.swift
This reverts commit 58ec714.
finestructure
force-pushed
the
parallelise-tests-6
branch
from
e99023a to
b0ac336
Compare
finestructure
force-pushed
the
parallelise-tests-6
branch
from
267b507 to
80b785c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB that part of that speedup is due to also dropping TSan for now.
Comparison of the latest run on this branch:
vs
main:Shaved off more than 5mins, 6.6x improvement.