Build with Swift 6.1 #3750
Merged
Build with Swift 6.1 #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .devcontainer/Dockerfile # .github/workflows/ci.yml # .github/workflows/query-performance.yml # Dockerfile # LOCAL_DEVELOPMENT_SETUP.md # Makefile
finestructure
commented
Apr 6, 2025
| .dependency(\.date.now, .t0), | ||
| .dependency(\.metricsSystem, .mock) | ||
| .dependency(\.metricsSystem, .mock), | ||
| .snapshots(record: .failed) |
There was a problem hiding this comment.
This is a great quality of life change in SnapshotTesting: The if a snapshot test fails, it will automatically record a new snapshot.
That means that in order to update snapshots, we don't need to edit tests anymore. We just need to check if there are snapshot differences and commit or revert them as needed.
finestructure
commented
Apr 6, 2025
| }, | ||
| "traits" : [ | ||
|
|
||
| ] |
There was a problem hiding this comment.
Swift 6.1 package dump format changes.
daveverwer
approved these changes
Apr 6, 2025
finestructure
added a commit
that referenced
this pull request
Apr 7, 2025
Revert "Merge pull request #3750 from SwiftPackageIndex/swift-6.1"
finestructure
added a commit
that referenced
this pull request
Apr 11, 2025
This reverts commit bd6b110.
finestructure
added a commit
that referenced
this pull request
Apr 17, 2025
This reverts commit bd6b110.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just switches the building and running of spi-server to 6.1.
I'm pulling this forward, because it's needed for parallel testing (and also the Xcode 16.3 update).