Skip to content

Added a note about disabling package collection signing #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2025
Merged

Added a note about disabling package collection signing #3772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d2b2d
Added a note about collection signing being temporarily disabled.
daveverwer Apr 18, 2025
4e2885a
Snapshots.
daveverwer Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/App/Views/Author/AuthorShow+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ enum AuthorShow {
),
.text(".")
),
.p(
.strong("Note:"),
.text(" Package collection signing is temporarily disabled. Package collections generated by Swift Package Index will still work, but you may get a certificate or security warning when using them."),
),
.copyableInputForm(buttonName: "Copy Package Collection URL",
eventName: "Copy Package Collection URL Button",
valueToCopy: SiteURL.packageCollectionAuthor(.value(model.owner)).absoluteURL()),
Expand Down
4 changes: 4 additions & 0 deletions Sources/App/Views/Keyword/KeywordShow+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ enum KeywordShow {
),
.text(".")
),
.p(
.strong("Note:"),
.text(" Package collection signing is temporarily disabled. Package collections generated by Swift Package Index will still work, but you may get a certificate or security warning when using them."),
),
.copyableInputForm(buttonName: "Copy Package Collection URL",
eventName: "Copy Package Collection URL Button",
valueToCopy: SiteURL.packageCollectionKeyword(.value(model.keyword)).absoluteURL()),
Expand Down
3 changes: 3 additions & 0 deletions Tests/AppTests/__Snapshots__/WebpageSnapshotTests/AuthorShow_document.1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ <h2 class="trimmed">Packages authored by Test Author</h2>
<p>These packages are available as a package collection,
<a href="/package-collections">usable in Xcode or SwiftPM</a>.
</p>
<p>
<strong>Note:</strong> Package collection signing is temporarily disabled. Package collections generated by Swift Package Index will still work, but you may get a certificate or security warning when using them.
</p>
<form class="copyable-input">
<input type="text" data-button-name="Copy Package Collection URL" data-event-name="Copy Package Collection URL Button" value="http://localhost:8080/test-author/collection.json" readonly/>
</form>
Expand Down
3 changes: 3 additions & 0 deletions Tests/AppTests/__Snapshots__/WebpageSnapshotTests/KeywordShow_document.1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ <h2 class="trimmed">Packages for keyword “networking”</h2>
<p>These packages are available as a package collection,
<a href="/package-collections">usable in Xcode or SwiftPM</a>.
</p>
<p>
<strong>Note:</strong> Package collection signing is temporarily disabled. Package collections generated by Swift Package Index will still work, but you may get a certificate or security warning when using them.
</p>
<form class="copyable-input">
<input type="text" data-button-name="Copy Package Collection URL" data-event-name="Copy Package Collection URL Button" value="http://localhost:8080/keywords/networking/collection.json" readonly/>
</form>
Expand Down
Loading