Skip to content

Maintenance updates #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Maintenance updates #3829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
172eb16
Update Grafana
finestructure Jun 23, 2025
485cecd
Widen acceptable success rate
finestructure Jun 23, 2025
728e49e
Package update
finestructure Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Sources/App/Commands/Alerting.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ extension [Alerting.BuildInfo] {
func validateSuccessRateInRange() -> Alerting.Validation {
let successRate = Double(filter { $0.status == .ok }.count) / Double(count)
// Success rate has been around 30% generally
if 0.2 <= successRate && successRate <= 0.4 {
if 0.15 <= successRate && successRate <= 0.45 {
return .ok
} else {
let percentSuccessRate = (successRate * 1000).rounded() / 10
Expand Down
8 changes: 4 additions & 4 deletions Tests/AppTests/AlertingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,20 +109,20 @@ extension AllTests.AlertingTests {
#expect(all.validateSuccessRateInRange() == .ok)
}
do {
let okCount = 199
let okCount = 149
let failedCount = 1000 - okCount
let okBuilds = (0..<okCount).map { _ in Alerting.BuildInfo.mock(status: .ok) }
let failedBuilds = (0..<failedCount).map { _ in Alerting.BuildInfo.mock(status: .failed) }
let all = okBuilds + failedBuilds
#expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 19.9% out of bounds"]))
#expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 14.9% out of bounds"]))
}
do {
let okCount = 401
let okCount = 451
let failedCount = 1000 - okCount
let okBuilds = (0..<okCount).map { _ in Alerting.BuildInfo.mock(status: .ok) }
let failedBuilds = (0..<failedCount).map { _ in Alerting.BuildInfo.mock(status: .failed) }
let all = okBuilds + failedBuilds
#expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 40.1% out of bounds"]))
#expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 45.1% out of bounds"]))
}
}

Expand Down
2 changes: 1 addition & 1 deletion mon.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ services:

grafana:
# https://github.com/grafana/grafana/releases
image: grafana/grafana:11.6.2
image: grafana/grafana:12.0.2
environment:
GF_SECURITY_ADMIN_PASSWORD: ${GF_SECURITY_ADMIN_PASSWORD}
GF_USERS_ALLOW_SIGN_UP: 'false'
Expand Down
Loading