Issue 3840 test failure #3841
Merged
Issue 3840 test failure #3841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
commented
Jul 22, 2025
| } else { | ||
| struct Response: Content { var message: String } | ||
| return try .tooManyRequests(jsonEncode: Response(message: "Too many pipelines created in the last minute. Try again later.")) | ||
| } |
There was a problem hiding this comment.
There was a logical race here where I'd properly locked the triggerCount value but the lock didn't span the whole of the operation that needed to be guarded. It could happen that all 32 tasks were run and saw a value < 5, because the increment happened on a later, separate lock than the check.
daveverwer
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3840