Skip to content

feat: Allow to rotate all nodeplugins at once. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Allow to rotate all nodeplugins at once. #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deploy/csi-rclone/templates/csi-nodeplugin-rclone.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@ spec:
name: pods-mount-dir
- mountPath: /var/lib/rclone
name: cache-dir
updateStrategy:
type: RollingUpdate
Copy link
Member

@rokroskar rokroskar Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you just want Recreate here?

Copy link
Member

@rokroskar rokroskar Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#recreate-deployment

Copy link
Author

@aledegano aledegano Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding daemonsets support different strategies:
https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/#daemonset-update-strategy and recreate is not one of those.
It might be interesting to see if we can use onDelete along with some Helm black sorcery to automate the process of rotating the nodeplugins when they are not in use...

rollingUpdate:
maxUnavailable: 100%
maxSurge: 100%
{{- with .Values.csiNodepluginRclone.nodeSelector }}
nodeSelector:
{{ toYaml . | nindent 8 }}
Expand Down