Skip to content

feat(check-pr-description): remove legacy switch and add support for slow switch #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −41
Open

feat(check-pr-description): remove legacy switch and add support for slow switch #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 17 additions & 41 deletions check-pr-description/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,14 @@ inputs:
description: String to search for in the PR description
required: false
default: "/deploy"
test-enabled-default:
description: Default value for test-enabled
required: false
default: "true"
test-enabled-switch-string:
description: String to switch the default behaviour for tests
test-disabled-switch-string:
description: String to disable tests
required: false
default: "#notest"
test-legacy-enabled-default:
description: Default value for test-legacy-enabled
required: false
default: "false"
test-legacy-enabled-switch-string:
description: String to switch the default behaviour for legacy tests
test-slow-enabled-switch-string:
description: String to enable slow tests; they won't run unless explicitly enabled
required: false
default: "#legacy"
default: "#slow"
outputs:
pr-contains-string:
description: true/false whether the PR description contains the string
Expand Down Expand Up @@ -67,9 +59,9 @@ outputs:
test-enabled:
description: whether the acceptance tests should run or not. Default is true
value: ${{ steps.check-string.outputs.test-enabled }}
test-legacy-enabled:
description: whether the legacy acceptance tests should run or not. Default is false
value: ${{ steps.check-string.outputs.test-legacy-enabled }}
test-slow-enabled:
description: whether the slow acceptance tests should run or not. Default is false
value: ${{ steps.check-string.outputs.test-slow-enabled }}
runs:
using: "composite"
steps:
Expand All @@ -80,16 +72,8 @@ runs:
pr_contains_string=$(echo $pr_text | jq 'test("${{ inputs.string }}")' || echo "false")
echo "pr-contains-string=$pr_contains_string" >> $GITHUB_OUTPUT
echo "String found: $pr_contains_string"
if [ "${{ inputs.test-enabled-default }}" = "true" ]; then
test_enabled=true
else
test_enabled=false
fi
if [ "${{ inputs.test-legacy-enabled-default }}" = "true" ]; then
test_legacy_enabled=true
else
test_legacy_enabled=false
fi
test_enabled=true
test_slow_enabled=false
if [ "$pr_contains_string" = true ] ; then
command=$(echo $pr_text | jq -r 'split("${{ inputs.string }} ") | last | split("\r\n") | first')
if [[ $command != *"${{ inputs.string }}"* ]]; then
Expand Down Expand Up @@ -149,21 +133,13 @@ runs:
echo "renku-search reference: ${BASH_REMATCH[1]}"
echo "renku-search=@${BASH_REMATCH[1]}" >> $GITHUB_OUTPUT
fi
match="${{ inputs.test-enabled-switch-string }}"
match="${{ inputs.test-disabled-switch-string }}"
if [[ $command =~ $match ]]; then
if [ "$test_enabled" = true ]; then
test_enabled=false
else
test_enabled=true
fi
test_enabled=false
fi
match="${{ inputs.test-legacy-enabled-switch-string }}"
match="${{ inputs.test-slow-enabled-switch-string }}"
if [[ $command =~ $match ]]; then
if [ "$test_legacy_enabled" = true ]; then
test_legacy_enabled=false
else
test_legacy_enabled=true
fi
test_slow_enabled=true
fi
match="extra-values=(\S*)"
if [[ $command =~ $match ]]; then
Expand All @@ -176,7 +152,7 @@ runs:
fi
echo "Test enabled: $test_enabled"
echo "test-enabled=${test_enabled}" >> $GITHUB_OUTPUT
echo "Legacy tests enabled: $test_legacy_enabled"
echo "test-legacy-enabled=${test_legacy_enabled}" >> $GITHUB_OUTPUT
echo "Slow tests enabled: $test_slow_enabled"
echo "test-slow-enabled=${test_slow_enabled}" >> $GITHUB_OUTPUT

shell: bash