Skip to content

feat: report buildrun failures to sentry #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: report buildrun failures to sentry #1124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7032431
feat: report buildrun failures to sentry
leafty Nov 28, 2025
620c950
also report not found
leafty Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions components/renku_data_services/session/k8s_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from typing import TYPE_CHECKING

import httpx
import sentry_sdk
from kr8s import NotFoundError, ServerError
from kr8s.asyncio.objects import APIObject, Pod

Expand Down Expand Up @@ -212,6 +213,11 @@ async def update_image_build_status(self, buildrun_name: str, user_id: str) -> m
k8s_build = await self.get_build_run(name=buildrun_name, user_id=user_id)

if k8s_build is None:
# Report this condition to Sentry: we expected to find a buildrun object but found none
try:
raise errors.ProgrammingError(message=f"Build run {buildrun_name} not found.")
except Exception as e:
sentry_sdk.capture_exception(e)
return models.ShipwrightBuildStatusUpdate(
update=models.ShipwrightBuildStatusUpdateContent(status=models.BuildStatus.failed)
)
Expand Down Expand Up @@ -274,6 +280,13 @@ async def update_image_build_status(self, buildrun_name: str, user_id: str) -> m
)
)
else:
# Report the failed buildrun to Sentry
try:
raise errors.ProgrammingError(message=f"Build run {buildrun_name} detected as failed.")
except Exception as e:
scope = sentry_sdk.get_current_scope()
scope.set_context(key="build_run", value=k8s_build.model_dump(mode="json"))
scope.capture_exception(e)
return models.ShipwrightBuildStatusUpdate(
update=models.ShipwrightBuildStatusUpdateContent(
status=models.BuildStatus.failed,
Expand Down